Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dav): close cursor when fetching max id #39297

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix(dav): close cursor when fetching max id #39297

merged 1 commit into from
Jul 12, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jul 11, 2023

  • Resolves: N/A

Summary

A small followup to #38639 as suggested by Joas.

#38920 (comment)
#38920 (comment)

Is already backported to all necessary branches (stable27 and stable26).

Checklist

@st3iny
fix(dav): close cursor when fetching max id
9206c0f 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny added bug 3. to review Waiting for reviews feature: caldav Related to CalDAV internals feature: carddav Related to CardDAV internals labels Jul 11, 2023
@st3iny st3iny added this to the Nextcloud 28 milestone Jul 11, 2023
@st3iny st3iny requested a review from nickvergessen July 11, 2023 06:08
@st3iny st3iny requested a review from ChristophWurst as a code owner July 11, 2023 06:08
@st3iny st3iny self-assigned this Jul 11, 2023
tcitworld
tcitworld approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nickvergessen nickvergessen merged commit e9ac028 into master Jul 12, 2023
@nickvergessen nickvergessen deleted the fix/dav/close-cursor branch July 12, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@tcitworld tcitworld tcitworld approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees

@st3iny st3iny

Labels
3. to review Waiting for reviews bug feature: caldav Related to CalDAV internals feature: carddav Related to CardDAV internals
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@st3iny @nickvergessen @tcitworld