Refactors "strpos" calls in /apps/dav #38610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsamapoor
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
tcitworld
approved these changes
Jun 2, 2023
ChristophWurst
approved these changes
Jun 2, 2023
Thanks for the clarification. I wasn't sure if I should keep those since there were only a couple of files that were taking advantage of this micro-optimization technique. Should I update all changed files and add use statements? |
|
It is nice to have but not a requirement |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
Co-authored-by: Thomas Citharel <tcit@tcit.fr> Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
szaimen
force-pushed
the
replace_strpos_calls_in_dav_app
branch
from
a3a6dfb to
8c64cca
Compare
szaimen
added
4. to release
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
|
Does anything need to be done for this to get merged? It's been more than three months. |
ChristophWurst
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following #38261 and #38260, I have replaced
strposcalls in/apps/davnamespace as well to improve code readability.