Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trap focus in dialogs #37780

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Trap focus in dialogs #37780

merged 2 commits into from
Apr 25, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Apr 18, 2023 •
edited
Loading

Summary

Focus is now trapped within dialogs

Checklist

@Pytal Pytal added the 2. developing Work in progress label Apr 18, 2023
@Pytal Pytal self-assigned this Apr 18, 2023
@Pytal Pytal mentioned this pull request Apr 18, 2023
Closed
2 tasks
@Pytal Pytal force-pushed the enh/a11y-focus-dialog branch from 9a1e917 to 1d6f379 Compare April 21, 2023 02:49
@Pytal Pytal changed the title [WIP] Trap focus in dialogs Trap focus in dialogs Apr 21, 2023
@Pytal Pytal marked this pull request as ready for review April 21, 2023 02:51
@Pytal Pytal added 3. to review Waiting for reviews accessibility and removed 2. developing Work in progress labels Apr 21, 2023
@Pytal Pytal added this to the Nextcloud 27 milestone Apr 21, 2023
@szaimen szaimen requested review from artonge and removed request for szaimen April 21, 2023 09:19
@artonge
Copy link
Contributor

artonge commented Apr 24, 2023

@hamza221 is nextcloud/photos#1711 still needed with this PR?

@artonge artonge mentioned this pull request Apr 24, 2023
Merged
@hamza221
Copy link
Contributor

hamza221 commented Apr 24, 2023 •
edited
Loading

@hamza221 is nextcloud/photos#1711 still needed with this PR?

it's not :)) , This is a cleaner and better approach

@hamza221 hamza221 mentioned this pull request Apr 24, 2023
Merged
@artonge artonge mentioned this pull request Apr 24, 2023
Closed
@artonge
Copy link
Contributor

artonge commented Apr 24, 2023

/backport to stable26

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 24, 2023
Pytal added 2 commits April 24, 2023 15:40
@Pytal
Add focus-trap
87ae9bb 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Trap focus in dialogs
79310bd 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/a11y-focus-dialog branch from 1d6f379 to 79310bd Compare April 24, 2023 22:46
@Pytal Pytal merged commit 721de34 into master Apr 25, 2023
@Pytal Pytal deleted the enh/a11y-focus-dialog branch April 25, 2023 00:05
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 25, 2023
Merged
1 task
@artonge artonge mentioned this pull request Apr 26, 2023
Closed
@ChristophWurst
Copy link
Member

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 6, 2023
Merged
1 task
@Pytal Pytal mentioned this pull request Jul 5, 2023
Closed
This was referenced Jun 2, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
5 participants
@Pytal @artonge @hamza221 @ChristophWurst @skjnldsv