Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue 35286 Firefox inconsistent scrolling #37297

Closed
wants to merge 2 commits into from

Conversation

sorbaugh
Copy link
Contributor

Summary

URL: #35286

Adding overflow-anchor: none to #app-content element within files.scss and re-minified files.css and merged.css.

Tested on Firefox 111.0 (64-Bit)

TODO

  • ...

Checklist

@szaimen szaimen added the 3. to review Waiting for reviews label Mar 19, 2023
@szaimen szaimen added this to the Nextcloud 27 milestone Mar 19, 2023
@szaimen szaimen added the bug label Mar 19, 2023
@szaimen szaimen requested review from miaulalala, a team, artonge, skjnldsv and Pytal and removed request for a team March 19, 2023 16:13
@artonge
Copy link
Contributor

artonge commented Mar 20, 2023

Can you also run npm ci and npm run build, and also amend your commit with a sign-off? Otherwise, CI will not pass.
https://github.com/nextcloud/server/pull/37297/checks?check_run_id=12112120394

@sorbaugh
Copy link
Contributor Author

Hello! I ran npm run build as requested, which altered 98 files in the /dist directory of my fork. The purpose of these changes seem to be mainly for cache-busting / adding a new version number to the source-mapping url.

Since I'm new to contributing in nextcloud and the main change is so small, it feels kind of overkill to commit this many files. So before I commit I wanted to ask if this is ok?

Best regards

@artonge
Copy link
Contributor

artonge commented Mar 22, 2023

Since I'm new to contributing in nextcloud and the main change is so small, it feels kind of overkill to commit this many files. So before I commit I wanted to ask if this is ok?

Indeed, not the best, but this is how we currently do things :) So you can commit and push those files.

Stephan added 2 commits March 22, 2023 21:38
URL: nextcloud#35286

Adding overflow-anchor: none to #app-content element within files.scss and re-minified files.css and merged.css.

Tested on Firefox 111.0 (64-Bit)

Signed-off-by: Stephan <stephan_orbaugh@outlook.de>
URL: nextcloud#35286

Added comment clarifying the purpose of the previous change.
Adding /dist files after npm run build

Tested on Firefox 111.0 (64-Bit)

Signed-off-by: Stephan Orbaugh <stephan_orbaugh@hotmail.com>
Signed-off-by: Stephan <stephan_orbaugh@outlook.de>
@sorbaugh
Copy link
Contributor Author

Ok I assume the conflicts with the /dist directory were to be expected if npm run build is run frequently :)

If everything else is alright and ready for merge, I can do a rebase.

@artonge
Copy link
Contributor

artonge commented Mar 29, 2023

If everything else is alright and ready for merge, I can do a rebase.

Yes, please rebase, compile, commit and push again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Firefox inconsistent scrolling
3 participants