-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Issue 35286 Firefox inconsistent scrolling #37297
Conversation
Can you also run |
Hello! I ran npm run build as requested, which altered 98 files in the /dist directory of my fork. The purpose of these changes seem to be mainly for cache-busting / adding a new version number to the source-mapping url. Since I'm new to contributing in nextcloud and the main change is so small, it feels kind of overkill to commit this many files. So before I commit I wanted to ask if this is ok? Best regards |
Indeed, not the best, but this is how we currently do things :) So you can commit and push those files. |
URL: nextcloud#35286 Adding overflow-anchor: none to #app-content element within files.scss and re-minified files.css and merged.css. Tested on Firefox 111.0 (64-Bit) Signed-off-by: Stephan <stephan_orbaugh@outlook.de>
URL: nextcloud#35286 Added comment clarifying the purpose of the previous change. Adding /dist files after npm run build Tested on Firefox 111.0 (64-Bit) Signed-off-by: Stephan Orbaugh <stephan_orbaugh@hotmail.com> Signed-off-by: Stephan <stephan_orbaugh@outlook.de>
Ok I assume the conflicts with the /dist directory were to be expected if npm run build is run frequently :) If everything else is alright and ready for merge, I can do a rebase. |
Yes, please rebase, compile, commit and push again :) |
Summary
URL: #35286
Adding overflow-anchor: none to #app-content element within files.scss and re-minified files.css and merged.css.
Tested on Firefox 111.0 (64-Bit)
TODO
Checklist