fix: wrong redirect when skipping recommended apps #37206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable26 |
kesselb
requested review from
a team,
skjnldsv,
Pytal and
szaimen
and removed request for
a team
tcitworld
reviewed
Mar 14, 2023
kesselb
force-pushed
the
fix-skip-recommended-apps-wrong-url
branch
from
5afd9dd to
5b37e06
Compare
tcitworld
reviewed
Mar 14, 2023
Comment on lines
133
to
136
| computed: { | ||
| defaultPageUrl() { | ||
| return defaultPageUrl | ||
| }, |
There was a problem hiding this comment.
suggestion (non-blocking): Data would be fine as well, since the value will not change.
There was a problem hiding this comment.
Thanks!
This version, with defaultPageUrl as a dedicated variable, does not seem to work.
It seems you need a computed property to access global variables or use loadState in data directly.
kesselb
force-pushed
the
fix-skip-recommended-apps-wrong-url
branch
from
5b37e06 to
94b5073
Compare
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
fix-skip-recommended-apps-wrong-url
branch
from
94b5073 to
e025cf0
Compare
Pytal
approved these changes
Apr 25, 2023
ChristophWurst
approved these changes
Apr 26, 2023
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin/stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
Due to the low impact, I'm skipping the outstanding backport for 26. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To access the page after setup:
index.php/core/apps/recommendedBefore
Screencast.from.2023-03-13.20-49-14.webm
After
Screencast.from.2023-03-13.20-48-10.webm
TODO
Checklist