Port admin delegation selects #36650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
requested review from
tcitworld,
JuliaKirschenheuter,
artonge and
szaimen
|
/backport to stable25 |
2 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -82,9 +82,11 @@ | |||
| $settings = array_merge( | |||
| $settings, | |||
| array_map(function (IDelegatedSettings $setting) use ($section) { | |||
| $sectionName = $section->getName() . ($setting->getName() !== null ? ' - ' . $setting->getName() : ''); | |||
Check notice
Code scanning / Psalm
PossiblyNullOperand
artonge
approved these changes
Feb 13, 2023
Merged
Pytal
force-pushed
the
enh/a11y-admin-delegation-select
branch
from
efc20d1 to
4690d15
Compare
|
Rebased |
artonge
approved these changes
Feb 27, 2023
|
💡 would be nice if the double approve counted as two separate ones |
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
enh/a11y-admin-delegation-select
branch
from
4690d15 to
db5d5c1
Compare
Pytal
added
4. to release
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist