Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] Fix compilation of Vue 2.7 features #36624

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Feb 9, 2023

Summary

The :deep() selector, introduced in Vue 2.7 alongside the deprecation of ::v-deep and subsequent un-deprecation in this commit vuejs/vue@2f335b2 released in Vue 2.7.11 https://github.com/vuejs/vue/blob/main/CHANGELOG.md#2711-2022-10-11, was not being compiled correctly and resulted in incorrect CSS output

/* Before */
#contactsmenu-menu:deep .emptycontent[data-v-e32bb484] {...
/* After */
#contactsmenu-menu[data-v-e32bb484] .emptycontent {...

We must explicitly bump vue-loader to 15.10.1 on stable25 as https://github.com/vuejs/vue-loader/releases/tag/v15.10.0 introduced support for Vue 2.7

This is needed on stable25 but not master as although both have vue-loader 15.9.8

"vue-loader": "^15.9.8",
"vue-loader": "^15.9.8",
, @nextcloud/webpack-vue-config is present
"@nextcloud/webpack-vue-config": "github:nextcloud/webpack-vue-config#master",
only on master which results in vue-loader being deduped to 15.10.1

This fixes the contacts menu styles

Before After
image image

Checklist

- Bump vue-loader from 15.9.8 to 15.10.1
- Fix contacts menu styles

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added this to the Nextcloud 25.0.4 milestone Feb 9, 2023
@Pytal Pytal self-assigned this Feb 9, 2023
@szaimen szaimen changed the title Fix compilation of Vue 2.7 features [stable25] Fix compilation of Vue 2.7 features Feb 9, 2023
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but didnt test

@szaimen szaimen mentioned this pull request Feb 9, 2023
@szaimen szaimen merged commit 5966a84 into stable25 Feb 9, 2023
@szaimen szaimen deleted the fix/vue-2.7-compilation branch February 9, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants