Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Update psalm-baseline.xml #36598

Merged
merged 1 commit into from
Feb 8, 2023
Merged

[master] Update psalm-baseline.xml #36598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 4 additions & 67 deletions build/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,12 +872,6 @@
<code>$files_list</code>
</InvalidArgument>
</file>
<file src="apps/files/appinfo/routes.php">
<InvalidScope occurrences="1">
<code>$this</code>
<code>$this</code>
</InvalidScope>
</file>
<file src="apps/files/lib/Activity/Provider.php">
<FalsableReturnStatement occurrences="1">
<code>$this-&gt;fileEncrypted[$fileId]</code>
Expand Down Expand Up @@ -1233,9 +1227,6 @@
<InvalidCatch occurrences="2"/>
</file>
<file src="apps/provisioning_api/lib/Controller/UsersController.php">
<InvalidScalarArgument occurrences="1">
<code>$quota</code>
</InvalidScalarArgument>
<TypeDoesNotContainNull occurrences="2">
<code>$groupid === null</code>
<code>$groupid === null</code>
Expand Down Expand Up @@ -2618,46 +2609,6 @@
<code>$storage-&gt;scanner</code>
</NoInterfaceProperties>
</file>
<file src="lib/private/Files/Storage/Wrapper/Availability.php">
<InvalidNullableReturnType occurrences="33">
<code>copy</code>
<code>copyFromStorage</code>
<code>file_exists</code>
<code>file_get_contents</code>
<code>file_put_contents</code>
<code>filemtime</code>
<code>filesize</code>
<code>filetype</code>
<code>fopen</code>
<code>free_space</code>
<code>getDirectDownload</code>
<code>getETag</code>
<code>getLocalFile</code>
<code>getMimeType</code>
<code>getOwner</code>
<code>getPermissions</code>
<code>hash</code>
<code>isCreatable</code>
<code>isDeletable</code>
<code>isReadable</code>
<code>isSharable</code>
<code>isUpdatable</code>
<code>is_dir</code>
<code>is_file</code>
<code>mkdir</code>
<code>moveFromStorage</code>
<code>opendir</code>
<code>rename</code>
<code>rmdir</code>
<code>search</code>
<code>stat</code>
<code>touch</code>
<code>unlink</code>
</InvalidNullableReturnType>
<InvalidReturnType occurrences="1">
<code>\Traversable</code>
</InvalidReturnType>
</file>
<file src="lib/private/Files/Storage/Wrapper/Encoding.php">
<InvalidScalarArgument occurrences="3">
<code>\Normalizer::FORM_C</code>
Expand Down Expand Up @@ -2689,18 +2640,17 @@
<code>$result</code>
<code>$this-&gt;copyFromStorage($sourceStorage, $sourceInternalPath . '/' . $file, $targetInternalPath . '/' . $file, false, $isRename)</code>
</InvalidOperand>
<InvalidReturnStatement occurrences="4">
<InvalidReturnStatement occurrences="3">
<code>$newUnencryptedSize</code>
<code>$result</code>
<code>$this-&gt;storage-&gt;file_get_contents($path)</code>
<code>$this-&gt;storage-&gt;filesize($path)</code>
</InvalidReturnStatement>
<InvalidReturnType occurrences="3">
<code>bool</code>
<code>int</code>
<code>string</code>
</InvalidReturnType>
<InvalidScalarArgument occurrences="5">
<InvalidScalarArgument occurrences="4">
<code>$lastChunkPos</code>
<code>$newUnencryptedSize</code>
<code>$size</code>
Expand All @@ -2723,9 +2673,8 @@
<InvalidReturnType occurrences="1">
<code>string</code>
</InvalidReturnType>
<InvalidScalarArgument occurrences="2">
<InvalidScalarArgument occurrences="1">
<code>$free</code>
<code>'ext'</code>
</InvalidScalarArgument>
</file>
<file src="lib/private/Files/Storage/Wrapper/Wrapper.php">
Expand Down Expand Up @@ -3483,9 +3432,6 @@
</UndefinedDocblockClass>
</file>
<file src="lib/private/legacy/OC_Files.php">
<InvalidScalarArgument occurrences="1">
<code>mt_rand()</code>
</InvalidScalarArgument>
<RedundantCondition occurrences="2">
<code>$getType === self::ZIP_DIR</code>
<code>$getType === self::ZIP_DIR</code>
Expand All @@ -3499,17 +3445,8 @@
<InvalidOperand occurrences="1">
<code>$matches[1][$last_match][0]</code>
</InvalidOperand>
<InvalidReturnStatement occurrences="2">
<code>(INF &gt; 0)? INF: PHP_INT_MAX</code>
<code>INF</code>
</InvalidReturnStatement>
<InvalidReturnType occurrences="1">
<code>int</code>
</InvalidReturnType>
<InvalidScalarArgument occurrences="3">
<code>$includeExtStorage ? 'ext' : false</code>
<InvalidScalarArgument occurrences="1">
<code>$path</code>
<code>'ext'</code>
</InvalidScalarArgument>
<RedundantCondition occurrences="1">
<code>count($obd_values) &gt; 0</code>
Expand Down