fix(authtoken): Store only one hash for authtokens with the current password per user #36562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
nickvergessen,
marcelklehr and
ChristophWurst
miaulalala
reviewed
Feb 6, 2023
|
Talk testing times look good again. But CI on server is unhappy (unit tests) |
ChristophWurst
approved these changes
Feb 7, 2023
juliusknorr
force-pushed
the
debug/session-hash-slowdown
branch
from
6a50ae0 to
7db99a4
Compare
juliusknorr
added
4. to release
5 tasks
…assword per user Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
debug/session-hash-slowdown
branch
from
7db99a4 to
580feec
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking auth token hashes takes quite some time. We can avoid checking each of them if we make sure that the same password also uses the same hash so we can quickly confirm that they do not need updates by just verifying one hash.
Waiting for CI at https://drone.nextcloud.com/nextcloud/spreed/11676/1/4