Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the profiler app branch to test with #36247

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

nickvergessen
Copy link
Member

So we can test in stable25 with a matching profiler version instead of master

Summary

TODO

Checklist

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nickvergessen
Copy link
Member Author

Arg, now it fails here because I recompiled the action code instead of patching it.
Some more work to be done with someone that knows the action I guess.

@nickvergessen
Copy link
Member Author

nickvergessen commented Jan 19, 2023

Or it's the rate limit or a one time error, because the checkout failed

So we can test in stable25 with a matching profiler version instead of master

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/bump-profiler-version branch from 5b9f2b4 to 793424a Compare January 20, 2023 15:36
@nickvergessen nickvergessen merged commit ad5a1ab into master Jan 23, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/bump-profiler-version branch January 23, 2023 06:02
@skjnldsv
Copy link
Member

@nickvergessen this PR introduced some warning in the actions:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants