Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command to update the 3rdparty submodule to the same branch as … #35610

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Dec 5, 2022

…the PR target

Instead of doing this by hand and sometimes pull stable25 in master or the other way around, I would be able to just comment «/update-3rdparty» once the PR on 3rdparty is merged.

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

@come-nc come-nc self-assigned this Dec 5, 2022
@come-nc
Copy link
Contributor Author

come-nc commented Dec 5, 2022

/update-3rdparty

@come-nc come-nc requested a review from skjnldsv December 5, 2022 17:24
@szaimen szaimen added this to the Nextcloud 26 milestone Dec 5, 2022
@szaimen szaimen added the 2. developing Work in progress label Dec 5, 2022
@szaimen
Copy link
Contributor

szaimen commented Dec 5, 2022

I like this 🚀

@skjnldsv
Copy link
Member

skjnldsv commented Dec 6, 2022

Can we document those commands? 🙈

@come-nc
Copy link
Contributor Author

come-nc commented Dec 6, 2022

/update-3rdparty

Does not seem to work. Any ideas?
@skjnldsv Or maybe I cannot test like this? Should the command be available in the PR or not?

@come-nc
Copy link
Contributor Author

come-nc commented Dec 6, 2022

Can we document those commands? see_no_evil

Sure, where?

@skjnldsv
Copy link
Member

skjnldsv commented Dec 6, 2022

Sure, where?

In the readme?

Or maybe I cannot test like this? Should the command be available in the PR or not?

Should be on the main branch, cannot trigger workflow from side branches :)

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@blizzz blizzz mentioned this pull request Feb 1, 2023
@come-nc come-nc modified the milestones: Nextcloud 26, Nextcloud 27 Feb 2, 2023
@max-nextcloud
Copy link
Contributor

/rebase

@max-nextcloud
Copy link
Contributor

@come-nc What's required to make this ready to be merged?

…the PR target

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@nextcloud-command nextcloud-command force-pushed the feat/add-update-3rdparty-command branch from eeefaa0 to dc262e5 Compare March 14, 2023 22:08
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
Copy link
Contributor

I gave adding the docs a try. Feel free to adjust / remove as you see fit.

@come-nc come-nc merged commit 325c310 into master Mar 15, 2023
@come-nc come-nc deleted the feat/add-update-3rdparty-command branch March 15, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants