Remove Bootstrap version reference from tooltip.scss #35485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
approved these changes
Nov 29, 2022
skjnldsv
approved these changes
Nov 29, 2022
|
It's the little things 😅 |
|
/compile amend / |
szaimen
added
4. to release
come-nc
approved these changes
Nov 29, 2022
We've had some reports that Nextcloud is using an outdated/deprecated Bootstrap version v3.3.5. I believe this to be caused by the string "Bootstrap v3.3.5" in the changed line, which after bundling ends up in `core-common.js`, and trips up some security scanners. It may also be worth investigating why the comments are not getting stripped when bundling the JS. Signed-off-by: Álvaro Brey <alvaro.brv@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
chore/remove-bootstrap-version-comment
branch
from
78de638 to
79c3970
Compare
nickvergessen
approved these changes
Nov 29, 2022
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
/backport to stable25 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had some reports that Nextcloud is using an outdated/deprecated Bootstrap version v3.3.5.
I believe this to be caused by the string "Bootstrap v3.3.5" removed in this PR, which after bundling ends up in
core-common.js, and trips up some security scanners.It may also be worth investigating why the comments are not getting stripped when bundling the JS.
cc @nickvergessen