Drop PHP 7.4 on master #34997

come-nc · 2022-11-07T09:56:22Z

Starting with 26 we will no longer support PHP 7.4
Bump the minimum version and start removing workaround specific to PHP 7.4

Bump PHP to 8.0 3rdparty#1215

Parent issue: #35025

apps/encryption/lib/Crypto/Crypt.php

@@ -470,8 +470,7 @@
 	 */
 	protected function isValidPrivateKey($plainKey) {
 		$res = openssl_get_privatekey($plainKey);
-		// TODO: remove resource check one php7.4 is not longer supported
-		if (is_resource($res) || (is_object($res) && get_class($res) === 'OpenSSLAsymmetricKey')) {
+		if (is_object($res) && get_class($res) === 'OpenSSLAsymmetricKey') {


apps/encryption/lib/Crypto/Crypt.php

@@ -160,11 +160,11 @@
 	/**
 	 * Generates a new private key
 	 *
-	 * @return resource
+	 * @return \OpenSSLAsymmetricKey|false


apps/encryption/lib/Crypto/Crypt.php

lib/private/Files/Storage/Wrapper/EncodingDirectoryWrapper.php

apps/user_ldap/ajax/wizard.php

 			\OC_JSON::error(['message' => $l->t('No data specified')]);
 			exit;
 		}
+		if (is_array($key)) {
+			\OC_JSON::error(['message' => $l->t('Invalid data specified')]);


come-nc · 2022-11-08T10:50:35Z

ref #35025

come-nc · 2022-12-13T16:08:00Z

@icewind1991 Would you be able to publish icewind1991/samba-krb-test-apache with PHP 8 so that CI using that can run?

.github/workflows/psalm-security.yml

come-nc · 2022-12-20T14:15:25Z

I merged the psalm-* workflows into the static-code-analysis one and it seems to work 👍
Only problem is it appears as «5,022 new alerts including 53 errors» but these are not new, they are the same as before. Not sure how to tell github these are not new.

lib/public/AppFramework/Db/Entity.php

ChristophWurst · 2022-12-27T13:44:54Z

Are there any parts of this PR that you could extract and submit separately?

skjnldsv · 2022-12-30T10:19:02Z

Rebased with latest actions changes. This PR should be a bit lighter now :)

skjnldsv · 2022-12-30T10:25:40Z

Considering the 891 files in from php cs, we can tackle that as a followup maybe! 🙈

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Signed-off-by: Joas Schilling <coding@schilljs.com>

It runs on a docker image on which we cannot control which PHP version runs. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

- DietPi-Software | Nextcloud: Assure that Nextcloud 25 is downloaded on Bullseye, since Nextcloud 26 won't support PHP 7.4 anymore: nextcloud/server#34997

Nextcloud 26 will require PHP 8.0 at least, see nextcloud/server#34997 Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>

Nextcloud 26 will require PHP 8.0 at least, see nextcloud/server#34997

DaphneMuller · 2023-02-21T13:10:41Z

hello @come-nc
Thank you so much for your work on this pull request! This ticket seems to have the tag 'pending documentation'.
Is there any chance you could clarify what documentation is missing? Is this for admins or for app developers?

MichaIng · 2023-02-21T14:32:40Z

At least here the PHP requirements table needs to be adjusted: https://github.com/nextcloud/documentation/blob/master/admin_manual/installation/system_requirements.rst
When touching it already, PHP 8.2 could be added as it is supported with Nextcloud 26.

There are further pages where PHP 7.4 is used as example, which should be updated to 8.1 or 8.2:

https://github.com/nextcloud/documentation/blob/master/admin_manual/installation/nginx-root.conf.sample
https://github.com/nextcloud/documentation/blob/master/admin_manual/installation/nginx-subdir.conf.sample
https://github.com/nextcloud/documentation/blob/master/admin_manual/installation/example_centos.rst If CentOS 8 does not provide PHP 8.x, then the example should be completely reworked to use e.g. CentOS 9 or another recent RPM distro.

come-nc · 2023-02-21T15:02:57Z

hello @come-nc Thank you so much for your work on this pull request! This ticket seems to have the tag 'pending documentation'. Is there any chance you could clarify what documentation is missing? Is this for admins or for app developers?

nextcloud/documentation#9650

come-nc · 2023-02-21T15:19:57Z

#34692 (comment)

come-nc added the 2. developing Work in progress label Nov 7, 2022

come-nc added this to the Nextcloud 26 milestone Nov 7, 2022

come-nc self-assigned this Nov 7, 2022

github-advanced-security bot found potential problems Nov 7, 2022

View reviewed changes

sunjam mentioned this pull request Nov 26, 2022

Nextcloud 26 Support nextcloud/nextcloudpi#1646

Closed

come-nc force-pushed the fix/drop-php-7.4 branch from 9b748c9 to ccc9792 Compare December 12, 2022 11:44

come-nc mentioned this pull request Dec 12, 2022

Drop PHP 7.4 from CI #35737

Closed

come-nc force-pushed the fix/drop-php-7.4 branch 2 times, most recently from 3deaae5 to f3a7d32 Compare December 13, 2022 09:48

This comment was marked as outdated.

Sign in to view

come-nc force-pushed the fix/drop-php-7.4 branch from 3068f16 to 9681038 Compare December 19, 2022 13:55

This comment was marked as outdated.

Sign in to view

come-nc force-pushed the fix/drop-php-7.4 branch from 23dc847 to 275e9ab Compare December 19, 2022 15:15

This comment was marked as outdated.

Sign in to view

nickvergessen reviewed Dec 20, 2022

View reviewed changes

.github/workflows/psalm-security.yml Outdated Show resolved Hide resolved

come-nc force-pushed the fix/drop-php-7.4 branch from 05ba539 to 4a71f1b Compare December 20, 2022 13:47

This comment was marked as outdated.

Sign in to view

come-nc mentioned this pull request Dec 22, 2022

Deprecation and removal of PHP7.4 support #35025

Closed

6 tasks

ChristophWurst reviewed Dec 27, 2022

View reviewed changes

lib/public/AppFramework/Db/Entity.php Show resolved Hide resolved

skjnldsv mentioned this pull request Dec 29, 2022

chore(actions): update php min supported to 8.0 #35911

Merged

skjnldsv force-pushed the fix/drop-php-7.4 branch from 4a71f1b to f6f0a78 Compare December 30, 2022 10:18

come-nc and others added 9 commits January 20, 2023 11:22

Update test file for mimetypes

de68fc6

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix integrity check

89dbc62

Signed-off-by: Joas Schilling <coding@schilljs.com>

Remove PHP version matrix from kerberos test

7e0a024

It runs on a docker image on which we cannot control which PHP version runs. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix Samba test failure details output

f8d222d

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fix check in integration tests

7b93a14

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Fixing samba test and adding details to kerberos job

55baa7b

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Show failure of SAML login in kerberos workflow

83d2655

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Always show the psalm baseline change, even on failure

d2204a7

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Bump 3rdparty to master branch

f32d18d

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

come-nc force-pushed the fix/drop-php-7.4 branch from bf9ab85 to f32d18d Compare January 20, 2023 10:22

come-nc merged commit 37bb33c into master Jan 20, 2023

come-nc deleted the fix/drop-php-7.4 branch January 20, 2023 10:43

come-nc mentioned this pull request Jan 20, 2023

Fix codestyle using codesniffer #36271

Merged

4 tasks

MichaIng added a commit to MichaIng/DietPi that referenced this pull request Jan 20, 2023

v8.14

8f0c2ef

- DietPi-Software | Nextcloud: Assure that Nextcloud 25 is downloaded on Bullseye, since Nextcloud 26 won't support PHP 7.4 anymore: nextcloud/server#34997

raimund-schluessler added a commit to nextcloud/tasks that referenced this pull request Jan 23, 2023

Don't test with Nextcloud master on PHP 7.4

27fd608

Nextcloud 26 will require PHP 8.0 at least, see nextcloud/server#34997 Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>

raimund-schluessler mentioned this pull request Jan 23, 2023

Don't test with Nextcloud master on PHP 7.4 nextcloud/tasks#2180

Merged

raimund-schluessler added a commit to raimund-schluessler/inventory that referenced this pull request Jan 23, 2023

Don't test with Nextcloud master on PHP 7.4

2a18dc6

Nextcloud 26 will require PHP 8.0 at least, see nextcloud/server#34997

raimund-schluessler mentioned this pull request Jan 23, 2023

Don't test with Nextcloud master on PHP 7.4 raimund-schluessler/inventory#244

Merged

ChristophWurst added the pending documentation This pull request needs an associated documentation update label Jan 30, 2023

ChristophWurst mentioned this pull request Feb 2, 2023

Drop php 7.4 support #34492

Closed

come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Feb 21, 2023

come-nc removed the pending documentation This pull request needs an associated documentation update label Feb 23, 2023

solracsf mentioned this pull request Apr 5, 2023

Remove PHP 7 rules from .htaccess #37604

Merged

4 tasks

ChristophWurst added the pending documentation This pull request needs an associated documentation update label Jun 12, 2023

ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Nov 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop PHP 7.4 on master #34997

Drop PHP 7.4 on master #34997

come-nc commented Nov 7, 2022 •

edited

Loading

come-nc commented Nov 8, 2022

This comment was marked as outdated.

come-nc commented Dec 13, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

come-nc commented Dec 20, 2022

This comment was marked as outdated.

ChristophWurst commented Dec 27, 2022

skjnldsv commented Dec 30, 2022

skjnldsv commented Dec 30, 2022

DaphneMuller commented Feb 21, 2023

MichaIng commented Feb 21, 2023

come-nc commented Feb 21, 2023

come-nc commented Feb 21, 2023

Drop PHP 7.4 on master #34997

Drop PHP 7.4 on master #34997

Conversation

come-nc commented Nov 7, 2022 • edited Loading

come-nc commented Nov 8, 2022

This comment was marked as outdated.

come-nc commented Dec 13, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

come-nc commented Dec 20, 2022

This comment was marked as outdated.

ChristophWurst commented Dec 27, 2022

skjnldsv commented Dec 30, 2022

skjnldsv commented Dec 30, 2022

DaphneMuller commented Feb 21, 2023

MichaIng commented Feb 21, 2023

come-nc commented Feb 21, 2023

come-nc commented Feb 21, 2023

come-nc commented Nov 7, 2022 •

edited

Loading