escape path prefix when doing cache jail search #34924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
a team,
juliusknorr,
CarlSchwan and
come-nc
and removed request for
a team
come-nc
approved these changes
Nov 3, 2022
|
/backport to stable25 |
|
/backport to stable24 |
|
The backport to stabe25 failed. Please do this backport manually. |
|
The backport to stable24 failed. Please do this backport manually. |
|
/backport to stable25 |
|
/backport to stable24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
CacheJaildoesn't escape the path of the jail when creating the search query for the files inside the jail. This doesn't break things since at most it will make the sql query return a few more results which will be filtered out in later steps.It does however interfere with the optimization step that is required for mysql to be able to use the "path prefix" index on the search query. Which does properly like-escape the paths.
This causes the "path prefix" index to not be used when a cache jail with an "_" in the path is part of the search. (This also includes any groupfolders since those always have "__groupfolders" in the search path)