Create a checksum of the config file in memory

[ativarsoft]

This fixes a massive performance bug when opcache is enabled.

Signed-off-by: Mateus de Lima Oliveira mateus@ativarsoft.com

[kesselb]

As reference: #34099

Thanks for creating a new version of your pull request 👍

Our usual workflow is that pull request target master as branch.
If necessary a patch is backported to the stable* branches (if possible by a bot).

Please don't forget to add the logging output (as requsted in the old pull request) to figure out what the actual issue is. The configuration file is only rewritten (and the opcache cleared) when a change is detected:

server/lib/private/Config.php

Lines 158 to 164 in c2dafb0

	if (!isset($this->cache[$key]) || $this->cache[$key] !== $value) {
	// Add change
	$this->cache[$key] = $value;
	return true;
	}
	return false;

[kesselb]

Target branch: master

[ativarsoft]

@kesselb

The log is empty, Daniel.

[kesselb]

Hey, when you change the target branch you may need to rebase your pull request. Right now all commits from stable24 which are not in master are also referenced.

[ativarsoft]

@kesselb, I have no idea how to resolve those rebase conflicts.

[kesselb]

It depends a bit on your local setup.

When people are working with a fork they usually add another remote "upstream".

git remote add upstream git@github.com:nextcloud/server.git

Then run git fetch upstream.

Afterwards rebase your local branch with the upstream changes git rebase -i upstream/master.

GitHub documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks

[come-nc]

This will never be true, the checksum computed from file use the whole file content while the current one use only the data.

[blizzz]

Any reason this PR is against stable24? Do we have a equivalent for master?

[kesselb]

Closing the pull request due to inactivity.