Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy in view-only mode #33713

Merged
merged 3 commits into from
Aug 26, 2022
Merged

Fix copy in view-only mode #33713

merged 3 commits into from
Aug 26, 2022

Conversation

PVince81
Copy link
Member

with shiny tests 🌟

@PVince81 PVince81 added the 3. to review Waiting for reviews label Aug 26, 2022
@PVince81 PVince81 added this to the Nextcloud 25 milestone Aug 26, 2022
@PVince81 PVince81 self-assigned this Aug 26, 2022
@PVince81 PVince81 added the bug label Aug 26, 2022
@PVince81
Copy link
Member Author

/backport to stable24

@PVince81
Copy link
Member Author

I forgot to adjust the frontend, incoming...

@PVince81
Copy link
Member Author

image

done

@PVince81
Copy link
Member Author

PVince81 commented Aug 26, 2022

seems my optimistic gherkin sentence extension broke other tests :-S

I'll have a look...

Asserts that downloading a view-only document returns 403.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 force-pushed the bugfix/noid/viewonlyfix branch from f68b329 to d1317e7 Compare August 26, 2022 12:18
@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 26, 2022
@skjnldsv skjnldsv merged commit 47584ee into master Aug 26, 2022
@skjnldsv skjnldsv deleted the bugfix/noid/viewonlyfix branch August 26, 2022 18:00
@blizzz blizzz mentioned this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants