Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n: Changed grammar #33475

Merged
merged 2 commits into from
Aug 31, 2022
Merged

l10n: Changed grammar #33475

merged 2 commits into from
Aug 31, 2022

Conversation

rakekniven
Copy link
Member

See https://en.wikipedia.org/wiki/32-bit_computing and related articles.

Reported at Transifex.

Signed-off-by: rakekniven 2069590+rakekniven@users.noreply.github.com

See https://en.wikipedia.org/wiki/32-bit_computing and related articles.

Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
@PVince81
Copy link
Member

the JS tests should also be adjusted https://github.com/nextcloud/server/runs/7706618833?check_suite_focus=true

Fixed tests for #33475 

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
@rakekniven
Copy link
Member Author

@PVince81 Adapted test, but another one is still failing.

@rakekniven
Copy link
Member Author

What can I do to get this PR merged?

@rakekniven
Copy link
Member Author

Ping

@szaimen szaimen added this to the Nextcloud 25 milestone Aug 31, 2022
@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish feature: language l10n and translations labels Aug 31, 2022
@szaimen
Copy link
Contributor

szaimen commented Aug 31, 2022

CI failure unrelated

@szaimen szaimen merged commit 4209dc7 into master Aug 31, 2022
@szaimen szaimen deleted the rakekniven-patch-1 branch August 31, 2022 17:34
@blizzz blizzz mentioned this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: language l10n and translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants