Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic property creations in test files #33425

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Aug 1, 2022

This fixes warnings in PHP 8.2

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

This fixes warnings in PHP 8.2

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc self-assigned this Aug 1, 2022
@come-nc come-nc requested review from a team, PVince81, blizzz, skjnldsv and CarlSchwan and removed request for a team August 2, 2022 08:57
@come-nc come-nc added this to the Nextcloud 25 milestone Aug 2, 2022
@come-nc come-nc added the 3. to review Waiting for reviews label Aug 2, 2022
@blizzz
Copy link
Member

blizzz commented Aug 2, 2022

CI though

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 2, 2022
@come-nc
Copy link
Contributor Author

come-nc commented Aug 2, 2022

Failure is unrelated

@come-nc come-nc merged commit 5cce1df into master Aug 2, 2022
@come-nc come-nc deleted the fix/fix-dynamic-properties-in-tests branch August 2, 2022 14:01
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants