Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to purge objects from the birthday calendar when it doesn't exist #33341

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Don't try to purge objects from the birthday calendar when it doesn't exist #33341

merged 1 commit into from
Jul 26, 2022

Conversation

tcitworld
Copy link
Member

@tcitworld tcitworld commented Jul 25, 2022 •
edited
Loading

Doesn't matter much as it's been recreated afterwards (with ensureCalendarExists).

Closes #29617

@tcitworld tcitworld added bug feature: caldav Related to CalDAV internals labels Jul 25, 2022
@tcitworld tcitworld added this to the Nextcloud 25 milestone Jul 25, 2022
@tcitworld tcitworld requested a review from a team July 25, 2022 13:17
@tcitworld tcitworld requested review from blizzz, skjnldsv and come-nc and removed request for a team July 25, 2022 13:17
@tcitworld tcitworld marked this pull request as ready for review July 25, 2022 13:18
@tcitworld tcitworld mentioned this pull request Jul 25, 2022
Closed
@tcitworld
Copy link
Member Author

/backport to stable24

@tcitworld
Copy link
Member Author

/backport to stable23

@tcitworld
Don't try to purge objects from the birthday calendar when it doesn't…
554e2dc 
… exist

Doesn't matter much as it's been recreated afterwards with (ensureCalendarExists).

Closes #29617

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld force-pushed the fix/29617/no-purge-when-birthday-calendar-doesnt-exist branch from 4be3353 to 554e2dc Compare July 25, 2022 15:56
@tcitworld tcitworld requested a review from blizzz July 25, 2022 15:58
@blizzz blizzz added the 3. to review Waiting for reviews label Jul 25, 2022
@blizzz blizzz merged commit 25d2099 into master Jul 26, 2022
@blizzz blizzz deleted the fix/29617/no-purge-when-birthday-calendar-doesnt-exist branch July 26, 2022 17:22
This was referenced Jul 26, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@miaulalala miaulalala miaulalala approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@come-nc come-nc Awaiting requested review from come-nc

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: caldav Related to CalDAV internals
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

Error: Trying to access array offset on value of type null at /apps/dav/lib/CalDAV/BirthdayService.php#306
3 participants
@tcitworld @blizzz @miaulalala