Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remake location property saving with Vue #33285

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Remake location property saving with Vue #33285

merged 1 commit into from
Aug 26, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jul 20, 2022 •
edited
Loading

"Address" renamed to "Location" on the UI, as suggested by @jancborchardt

Requires

@Pytal Pytal added this to the Nextcloud 25 milestone Jul 20, 2022
@Pytal Pytal self-assigned this Jul 20, 2022
@Pytal Pytal mentioned this pull request Jul 20, 2022
Closed
11 tasks
@Pytal Pytal force-pushed the enh/27869/twitter branch 2 times, most recently from edbce9e to 77f73f8 Compare July 26, 2022 00:51
@Pytal Pytal force-pushed the enh/27869/location branch from 57e6999 to 3eeb22f Compare July 26, 2022 01:17
@github-actions
Copy link
Contributor

Possible performance regression detected

Show Output 
1 queries added

≠ /remote.php/dav/files/test with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/test.txt with 1 queries removed
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/many_files with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt
= /remote.php/dav/files/test/new_file.txt

@Pytal Pytal force-pushed the enh/27869/twitter branch from 77f73f8 to 13ca063 Compare July 27, 2022 00:19
@Pytal Pytal force-pushed the enh/27869/location branch from 3eeb22f to c8cf148 Compare July 27, 2022 00:28
@Pytal Pytal force-pushed the enh/27869/twitter branch from 13ca063 to 91fc449 Compare July 27, 2022 00:53
@Pytal Pytal force-pushed the enh/27869/location branch 2 times, most recently from 50f134c to 1675907 Compare July 28, 2022 00:35
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 28, 2022
@Pytal Pytal force-pushed the enh/27869/twitter branch 6 times, most recently from 7e0cd45 to 7fd6634 Compare July 29, 2022 20:16
@Pytal Pytal force-pushed the enh/27869/location branch from 1675907 to a45d72c Compare July 29, 2022 20:22
@Pytal Pytal force-pushed the enh/27869/twitter branch from 7fd6634 to df757f3 Compare August 9, 2022 03:09
@Pytal Pytal force-pushed the enh/27869/location branch from a45d72c to 7dd57f1 Compare August 9, 2022 03:12
@Pytal Pytal force-pushed the enh/27869/twitter branch from df757f3 to 257ab46 Compare August 11, 2022 02:12
@skjnldsv skjnldsv mentioned this pull request Aug 12, 2022
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 18, 2022
Merged
@blizzz blizzz mentioned this pull request Aug 24, 2022
Merged
@Pytal Pytal force-pushed the enh/27869/twitter branch from 257ab46 to 09f6eb5 Compare August 25, 2022 18:19
Base automatically changed from enh/27869/twitter to master August 25, 2022 21:40
@Pytal
Remake location property saving with Vue
dd7cb97 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/27869/location branch from 7dd57f1 to dd7cb97 Compare August 25, 2022 23:52
@Pytal
Copy link
Member Author

Pytal commented Aug 26, 2022

Rebased

@Pytal Pytal requested review from a team, PVince81, artonge and skjnldsv and removed request for a team August 26, 2022 00:40
@Pytal Pytal marked this pull request as ready for review August 26, 2022 00:40
@Pytal Pytal requested a review from CarlSchwan as a code owner August 26, 2022 00:40
PVince81
PVince81 approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit e69ad6f into master Aug 26, 2022
@PVince81 PVince81 deleted the enh/27869/location branch August 26, 2022 06:42
@blizzz blizzz mentioned this pull request Aug 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge Awaiting requested review from artonge

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility enhancement feature: accessibility feature: settings
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @PVince81 @skjnldsv