Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to set a different primary color for dark themes #32500

Closed
wants to merge 1 commit into from

Conversation

artonge
Copy link
Contributor

@artonge artonge commented May 19, 2022

The primary color can be in-adapted to dark theme, this new settings allow to choose a different one.
If the color for dark theme is not set, it will default to the primary one.

Screencast from 19-05-2022 15:57:37

@artonge artonge added 3. to review Waiting for reviews feature: theming labels May 19, 2022
@artonge artonge added this to the Nextcloud 25 milestone May 19, 2022
@artonge artonge self-assigned this May 19, 2022
@artonge artonge requested review from skjnldsv, a team, PVince81 and Pytal and removed request for a team May 19, 2022 14:05
The primary color can be inadapted to dark colors, this new settings allow to choose a different one.

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the feature/primary_color_for_dark_themes branch from 9183070 to da1a91f Compare May 19, 2022 15:20
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking

@skjnldsv
Copy link
Member

see for fix #32509

@skjnldsv skjnldsv deleted the feature/primary_color_for_dark_themes branch March 14, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants