Fix undefined values fallback in profileParameters #29321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
added
bug
2. developing
|
This is fixed by #29330 on the backend — we can do this as well for extra safety :) |
|
oh, I see lots of conflicts now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #28751
While the ES6 destructuring syntax is fancy, it doesn't offers proper undefined fallback.
Either we do it like I suggest or we use a proper full object fallback as the
loadStatefallback parameterIt seems this still doesn't fixes everything as I'm personally still missing some values:
I assume this is because I'm on a dev and wild instance, but I want to still make sure we catch that to ensure no one else also encounter that issue 😄