Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont apply jail search filter is on the root #28175

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Conversation

icewind1991
Copy link
Member

the extra '/' breaks things and the filter wouldn't do anything anyway except making the databases job harder

Fixes #28108

@pmarini-nc @xadhoom76 can you check if this fixes the problem for you

the extra '/' breaks things and the filter wouldn't do anything anyway except making the databases job harder

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jul 26, 2021
@icewind1991 icewind1991 added this to the Nextcloud 23 milestone Jul 26, 2021
@icewind1991
Copy link
Member Author

/backport to stable22

@icewind1991
Copy link
Member Author

/backport to stable21

@icewind1991
Copy link
Member Author

/backport to stable20

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 tested, works

@icewind1991 can you also adjust the unit tests ?

Signed-off-by: Robin Appelman <robin@icewind.nl>
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 28, 2021
@juliusknorr juliusknorr merged commit db7ffb0 into master Jul 29, 2021
@juliusknorr juliusknorr deleted the jail-search-root branch July 29, 2021 07:27
@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@PVince81
Copy link
Member

The backport to stable20 failed. Please do this backport manually.

#28235 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No matches for search in external storage when external storage is not available for user but shared for user
3 participants