Move log out and backup codes link into 2fa box for better readability

[ChristophWurst]

Fixes #2538

Without backup codes

With backup codes

[mention-bot]

@ChristophWurst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @MorrisJobke and @icewind1991 to be potential reviewers.

[skjnldsv]

Could we use buttons for the "cancel login" and "use backup code" ? :)

Otherwise: 👍

[jancborchardt]

Also, the »Authenticate with a TOTP app« doesn’t look clickable really. We should use a button there, which should be as big as the input field (or button on the log in page).

Then smaller side-by-side buttons for the options below.

[ChristophWurst]

Also, the »Authenticate with a TOTP app« doesn’t look clickable really. We should use a button there, which should be as big as the input field (or button on the log in page).

https://github.com/nextcloud/server/blob/master/core/templates/twofactorselectchallenge.php have fun :-)

Then smaller side-by-side buttons for the options below.

That's what we had before but depending on the language the text can be too long for one line. For example the German translation caused it to break, which looked odd. I'd prefer to have one below the other because that's easier to read IMO.

[ChristophWurst]

@jancborchardt could you please help me with the styling here? I don't know what it should look like :-)

[rullzer]

Can we get this in and fix additional styling later or close this?

[skjnldsv]

@rullzer please wait for my login-update-install css fix.
Then it will be easier :)

[skjnldsv]

Okay, see #3004

[jancborchardt]

#3004 is merged, so we can go ahead here? :)

@ChristophWurst just using class="button primary" for the primary button (»Auth with TOTP app«) and class="button" for the other two ones (»Cancel log in« and »Use backup code«) should work nicely. :)

[ChristophWurst]

blocked by #3207

[codecov-io]

Codecov Report

Merging #2618 into master will increase coverage by -0.01%.

@@             Coverage Diff              @@
##             master    #2618      +/-   ##
============================================
- Coverage     53.99%   53.98%   -0.01%     
  Complexity    21007    21007              
============================================
  Files          1303     1303              
  Lines         80377    80383       +6     
  Branches       1253     1253              
============================================
+ Hits          43396    43397       +1     
- Misses        36981    36986       +5

Impacted Files	Coverage Δ	Complexity Δ
core/templates/twofactorselectchallenge.php	0% <ø> (ø)	0 <ø> (ø)	❌
core/templates/twofactorshowchallenge.php	0% <ø> (ø)	0 <ø> (ø)	❌
lib/private/Server.php	92.75% <ø> (+0.16%)	119% <ø> (ø)	❌

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa96b9e...321a026. Read the comment docs.

[MorrisJobke]

blocked by #3207

Merged -> unblocked 😝

[MorrisJobke]

@ChristophWurst Any news here? I would love to see this merged ;)

[skjnldsv]

While you're at it, could you set the default mobile keyboard to number only @ChristophWurst :)
http://mobileinputtypes.com/#tel

[ChristophWurst]

@jancborchardt I've changed the links to buttons. Doesn't look good IMO. Could you please help me with the styling? Thanks

[rullzer]

@jancborchardt please have a look here. Else I'll just merge it and you have to fix master 😉

[ChristophWurst]

@rullzer so… merge? 😉