Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove explicit fclose from S3->writeStream #26072

Merged
merged 1 commit into from
Mar 12, 2021
Merged

remove explicit fclose from S3->writeStream #26072

merged 1 commit into from
Mar 12, 2021

Conversation

icewind1991
Copy link
Member

streams get closed automatically when dropped, and in some cases the stream seems to be already closed by the S3 library, in which case trying to close it again will raise an error

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991
remove explicit fclose from S3->writeStream
3eb764e 
streams get closed automatically when dropped, and in some cases the stream seems to be already closed by the S3 library, in which case trying to close it again will raise an error

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added this to the Nextcloud 22 milestone Mar 11, 2021
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 11, 2021
@PVince81
Copy link
Member

reminds me of some old nightmares about the garbage collector and fclose errors as it was happening too late: owncloud/core#22370 (comment)

I hope this is obsolete nowadays.

PVince81
PVince81 approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rullzer rullzer merged commit 98d2f3b into master Mar 12, 2021
@rullzer rullzer deleted the s3-no-explicit-close branch March 12, 2021 07:21
@kesselb
Copy link
Contributor

kesselb commented Mar 16, 2021

What do you think about a backport?

@kesselb
Copy link
Contributor

kesselb commented Mar 17, 2021

/backport to stable21

@kesselb
Copy link
Contributor

kesselb commented Mar 17, 2021

/backport to stable20

@kesselb
Copy link
Contributor

kesselb commented Mar 17, 2021

/backport to stable19

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 17, 2021
Merged
This was referenced Mar 17, 2021
Merged
Merged
@PVince81 PVince81 mentioned this pull request Mar 18, 2021
Closed
@kesselb kesselb mentioned this pull request Apr 16, 2021
Closed
@st3iny st3iny mentioned this pull request May 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
5 participants
@icewind1991 @PVince81 @kesselb @juliusknorr @rullzer