Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable20] Update psalm baseline #25876

Merged
merged 3 commits into from
Mar 17, 2021
Merged

[stable20] Update psalm baseline #25876

merged 3 commits into from
Mar 17, 2021

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Mar 2, 2021

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer rullzer added enhancement 2. developing Work in progress labels Mar 2, 2021
@rullzer rullzer added this to the Nextcloud 20.0.9 milestone Mar 2, 2021
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@PVince81 PVince81 force-pushed the psalm/stable20/update branch from e37f5a8 to 4b1a98c Compare March 17, 2021 09:07
@PVince81
Copy link
Member

rebased and adjusted based on CI message (psalm baseline update times out for me locally)

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 force-pushed the psalm/stable20/update branch from 4b1a98c to f80f7a3 Compare March 17, 2021 09:31
@PVince81 PVince81 self-assigned this Mar 17, 2021
Backported some bits of stable21 to make Psalm happy.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81
Copy link
Member

had to update some baseline entries manually and backport some tiny phpdoc / types changes from stable21

@PVince81 PVince81 added 3. to review Waiting for reviews bug and removed 2. developing Work in progress enhancement labels Mar 17, 2021
@PVince81
Copy link
Member

static checks are green again 🎉

@PVince81 PVince81 requested a review from kesselb March 17, 2021 11:16
@MorrisJobke MorrisJobke merged commit 3c1402c into stable20 Mar 17, 2021
@MorrisJobke MorrisJobke deleted the psalm/stable20/update branch March 17, 2021 13:17
This was referenced Mar 26, 2021
@rullzer rullzer mentioned this pull request Apr 8, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants