Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused private ForwardEmitter and LegacyEmitter #23766

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Remove unused private ForwardEmitter and LegacyEmitter #23766

merged 1 commit into from
Oct 29, 2020

Conversation

MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Oct 28, 2020 •
edited
Loading

Found while checking code for #14552.

I couldn't find any usages in the code base and it's private namespace anyways.

@MorrisJobke
Remove unused private ForwardEmitter and LegacyEmitter
6e35457 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added this to the Nextcloud 21 milestone Oct 28, 2020
@faily-bot
Copy link

faily-bot bot commented Oct 28, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34714: failure

samba

Show full log 
There was 1 failure:

1) OCA\Files_External\Tests\Storage\SmbTest::testNotifyGetChanges
Actual changes are:
Array
(
    [0] => OC\Files\Notify\Change Object
        (
            [type:OC\Files\Notify\Change:private] => 1
            [path:OC\Files\Notify\Change:private] => newfile.txt
        )

    [1] => OC\Files\Notify\RenameChange Object
        (
            [targetPath:OC\Files\Notify\RenameChange:private] => renamed.txt
            [type:OC\Files\Notify\Change:private] => 4
            [path:OC\Files\Notify\Change:private] => newfile.txt
        )

    [2] => OC\Files\Notify\Change Object
        (
            [type:OC\Files\Notify\Change:private] => 2
            [path:OC\Files\Notify\Change:private] => renamed.txt
        )

)

Failed asserting that an array contains OC\Files\Notify\RenameChange Object &00000000260e3db500000000436bef6f (
    'targetPath' => 'renamed.txt'
    'type' => 4
    'path' => 'newfile.txt'
).

/drone/src/apps/files_external/tests/Storage/SmbTest.php:126

mariadb10.1-php7.3

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testMoveOverwrite with data set #5 ('/sòurcē.txt', '/target.txt')
Expected /target.txt to be a copy of /drone/src/tests/data/lorem.txt
Failed asserting that false matches expected 'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.\n
Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.\n
Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.\n
Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'.

/drone/src/tests/lib/Files/Storage/Storage.php:222
/drone/src/tests/lib/Files/Storage/Storage.php:277

mariadb10.4-php7.4

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

mysql8.0-php7.4

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

mysql5.6-php7.3

Show full log 
There was 1 error:

1) OCA\Federation\Tests\BackgroundJob\GetSharedSecretTest::testExecute with data set #0 (true, true)
TypeError: Argument 2 passed to OCA\DAV\Events\CalendarCreatedEvent::__construct() must be of the type array, null given, called in /drone/src/apps/dav/lib/CalDAV/CalDavBackend.php on line 790

/drone/src/apps/dav/lib/Events/CalendarCreatedEvent.php:51
/drone/src/apps/dav/lib/CalDAV/CalDavBackend.php:790
/drone/src/apps/dav/lib/HookManager.php:157
/drone/src/apps/dav/lib/AppInfo/Application.php:131
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:264
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:239
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:73
/drone/src/lib/private/EventDispatcher/SymfonyAdapter.php:85
/drone/src/lib/private/User/Session.php:569
/drone/src/lib/private/User/Session.php:415
/drone/src/lib/private/User/Session.php:624
/drone/src/lib/private/User/Session.php:367
/drone/src/apps/files_sharing/tests/TestCase.php:201
/drone/src/apps/files_sharing/tests/TestCase.php:114
/drone/src/apps/federation/tests/BackgroundJob/GetSharedSecretTest.php:85

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

@MorrisJobke
Copy link
Member Author

Status before the re-trigger of CI:

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34714: failure

samba

Show full log 
There was 1 failure:

1) OCA\Files_External\Tests\Storage\SmbTest::testNotifyGetChanges
Actual changes are:
Array
(
    [0] => OC\Files\Notify\Change Object
        (
            [type:OC\Files\Notify\Change:private] => 1
            [path:OC\Files\Notify\Change:private] => newfile.txt
        )

    [1] => OC\Files\Notify\RenameChange Object
        (
            [targetPath:OC\Files\Notify\RenameChange:private] => renamed.txt
            [type:OC\Files\Notify\Change:private] => 4
            [path:OC\Files\Notify\Change:private] => newfile.txt
        )

    [2] => OC\Files\Notify\Change Object
        (
            [type:OC\Files\Notify\Change:private] => 2
            [path:OC\Files\Notify\Change:private] => renamed.txt
        )

)

Failed asserting that an array contains OC\Files\Notify\RenameChange Object &00000000260e3db500000000436bef6f (
    'targetPath' => 'renamed.txt'
    'type' => 4
    'path' => 'newfile.txt'
).

/drone/src/apps/files_external/tests/Storage/SmbTest.php:126

mariadb10.1-php7.3

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testMoveOverwrite with data set #5 ('/sòurcē.txt', '/target.txt')
Expected /target.txt to be a copy of /drone/src/tests/data/lorem.txt
Failed asserting that false matches expected 'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.\n
Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.\n
Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.\n
Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'.

/drone/src/tests/lib/Files/Storage/Storage.php:222
/drone/src/tests/lib/Files/Storage/Storage.php:277

mariadb10.4-php7.4

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

mysql8.0-php7.4

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

mysql5.6-php7.3

Show full log 
There was 1 error:

1) OCA\Federation\Tests\BackgroundJob\GetSharedSecretTest::testExecute with data set #0 (true, true)
TypeError: Argument 2 passed to OCA\DAV\Events\CalendarCreatedEvent::__construct() must be of the type array, null given, called in /drone/src/apps/dav/lib/CalDAV/CalDavBackend.php on line 790

/drone/src/apps/dav/lib/Events/CalendarCreatedEvent.php:51
/drone/src/apps/dav/lib/CalDAV/CalDavBackend.php:790
/drone/src/apps/dav/lib/HookManager.php:157
/drone/src/apps/dav/lib/AppInfo/Application.php:131
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:264
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:239
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:73
/drone/src/lib/private/EventDispatcher/SymfonyAdapter.php:85
/drone/src/lib/private/User/Session.php:569
/drone/src/lib/private/User/Session.php:415
/drone/src/lib/private/User/Session.php:624
/drone/src/lib/private/User/Session.php:367
/drone/src/apps/files_sharing/tests/TestCase.php:201
/drone/src/apps/files_sharing/tests/TestCase.php:114
/drone/src/apps/federation/tests/BackgroundJob/GetSharedSecretTest.php:85

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Oct 29, 2020
ChristophWurst
ChristophWurst approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 💥 🥇

rullzer
rullzer approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎵 we didn't start the fire 🎵

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 29, 2020
@MorrisJobke MorrisJobke merged commit e5cd4ea into master Oct 29, 2020
@MorrisJobke MorrisJobke deleted the techdebt/noid/remove-unused-private-emitters branch October 29, 2020 09:03
@MorrisJobke MorrisJobke mentioned this pull request Oct 29, 2020
Closed
@MorrisJobke MorrisJobke removed the pending documentation This pull request needs an associated documentation update label Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@PVince81 PVince81 Awaiting requested review from PVince81

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@kesselb kesselb Awaiting requested review from kesselb

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@gary-kim gary-kim Awaiting requested review from gary-kim

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 21
Development

Successfully merging this pull request may close these issues.
3 participants
@MorrisJobke @rullzer @ChristophWurst