-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emit typed event for user management #22649
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Psalm's complaint is unrelated. |
61c22d4
to
023e52e
Compare
ChristophWurst
approved these changes
Sep 7, 2020
023e52e
to
c9a6e23
Compare
c9a6e23
to
895a750
Compare
895a750
to
249a585
Compare
should be mentioned then in #20953 (comment) as well |
kesselb
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
ci says no |
249a585
to
452c86c
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
452c86c
to
f959828
Compare
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 32860: failurejsunitShow full log
integration-sharing-v1-video-verification
Show full log
|
MorrisJobke
added a commit
to nextcloud/documentation
that referenced
this pull request
Oct 29, 2020
See nextcloud/server#22649 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
backportbot-nextcloud bot
pushed a commit
to nextcloud/documentation
that referenced
this pull request
Oct 29, 2020
See nextcloud/server#22649 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next to the legacy event, fire a typed event. Needed for impersonate's IBootstrap implementation