Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect unreadable state in the UI #21185

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Reflect unreadable state in the UI #21185

merged 1 commit into from
Jun 10, 2020

Conversation

nickvergessen
Copy link
Member

When you have an external mount point mounted that is not readable, we mark them gray in the UI to avoid unnecessary clicks

@nickvergessen nickvergessen added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: files labels Jun 2, 2020
@nickvergessen nickvergessen added this to the Nextcloud 20 milestone Jun 2, 2020
GretaD
GretaD approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine, but i dont know how to test it

@nickvergessen
Reflect unreadable state in the UI
31e9ab4 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

  1. Create a folder
  2. Apply a tag to it
  3. Enable "files_accesscontrol"
  4. Set up a workflow to block access on the tag of "2."
  5. Check your file list

@nickvergessen
Copy link
Member Author

Rebased, lets get this in

@nickvergessen nickvergessen force-pushed the bugfix/noid/reflect-unreadable-state-in-ui branch from a4284e1 to 31e9ab4 Compare June 10, 2020 07:37
@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 10, 2020
@nickvergessen nickvergessen merged commit 83303ef into master Jun 10, 2020
@nickvergessen nickvergessen deleted the bugfix/noid/reflect-unreadable-state-in-ui branch June 10, 2020 08:54
@nickvergessen
Copy link
Member Author

/backport to stable19

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@GretaD GretaD GretaD approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. feature: files
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @ChristophWurst @GretaD