Log untyped server DI requests #19347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
approved these changes
Feb 7, 2020
ChristophWurst
added
the
pending documentation
|
See |
o sure. But lets fix them separately. My fixup commit was there because otherwise there is a cycle causing infinite reccursion/ |
icewind1991
approved these changes
Feb 12, 2020
rullzer
force-pushed
the
fix/19345/log_deprecated_alias_use
branch
from
7f0effd to
69eefad
Compare
Fixes #19345 Basically just a stupid wrapper with extra logging. So that we can at least inform people they are using the wrong methods. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
fix/19345/log_deprecated_alias_use
branch
from
73a6feb to
c1152af
Compare
nickvergessen
approved these changes
Mar 17, 2020
ChristophWurst
removed
the
pending documentation
ChristophWurst
added a commit
to nextcloud/documentation
that referenced
this pull request
Apr 10, 2020
Ref nextcloud/server#19347 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added a commit
to nextcloud/documentation
that referenced
this pull request
Apr 10, 2020
Ref nextcloud/server#19347 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19345
Basically just a stupid wrapper function to log this kind of things so we can fix them step by step.
Only logs on debug right now.