-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple remote wipe notifcation channels with events #15775
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/** | ||
* @copyright 2019 Christoph Wurst <christoph@winzerhof-wurst.at> | ||
* | ||
* @author 2019 Christoph Wurst <christoph@winzerhof-wurst.at> | ||
* | ||
* @license GNU AGPL version 3 or any later version | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License as | ||
* published by the Free Software Foundation, either version 3 of the | ||
* License, or (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
namespace OC\Authentication\Events; | ||
|
||
use OC\Authentication\Token\IToken; | ||
use OCP\EventDispatcher\Event; | ||
use Symfony\Component\EventDispatcher\GenericEvent; | ||
|
||
abstract class ARemoteWipeEvent extends Event { | ||
|
||
/** @var IToken */ | ||
private $token; | ||
|
||
public function __construct(IToken $token) { | ||
parent::__construct(); | ||
$this->token = $token; | ||
} | ||
|
||
public function getToken(): IToken { | ||
return $this->token; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/** | ||
* @copyright 2019 Christoph Wurst <christoph@winzerhof-wurst.at> | ||
* | ||
* @author 2019 Christoph Wurst <christoph@winzerhof-wurst.at> | ||
* | ||
* @license GNU AGPL version 3 or any later version | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License as | ||
* published by the Free Software Foundation, either version 3 of the | ||
* License, or (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
namespace OC\Authentication\Events; | ||
|
||
class RemoteWipeFinished extends ARemoteWipeEvent { | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/** | ||
* @copyright 2019 Christoph Wurst <christoph@winzerhof-wurst.at> | ||
* | ||
* @author 2019 Christoph Wurst <christoph@winzerhof-wurst.at> | ||
* | ||
* @license GNU AGPL version 3 or any later version | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License as | ||
* published by the Free Software Foundation, either version 3 of the | ||
* License, or (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
namespace OC\Authentication\Events; | ||
|
||
class RemoteWipeStarted extends ARemoteWipeEvent { | ||
|
||
} |
80 changes: 80 additions & 0 deletions
80
lib/private/Authentication/Listeners/RemoteWipeActivityListener.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/** | ||
* @copyright 2019 Christoph Wurst <christoph@winzerhof-wurst.at> | ||
* | ||
* @author 2019 Christoph Wurst <christoph@winzerhof-wurst.at> | ||
* | ||
* @license GNU AGPL version 3 or any later version | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License as | ||
* published by the Free Software Foundation, either version 3 of the | ||
* License, or (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
namespace OC\Authentication\Listeners; | ||
|
||
use BadMethodCallException; | ||
use OC\Authentication\Events\ARemoteWipeEvent; | ||
use OC\Authentication\Events\RemoteWipeFinished; | ||
use OC\Authentication\Events\RemoteWipeStarted; | ||
use OC\Authentication\Token\IToken; | ||
use OCP\Activity\IManager as IActvityManager; | ||
use OCP\EventDispatcher\Event; | ||
use OCP\EventDispatcher\IEventListener; | ||
use OCP\ILogger; | ||
|
||
class RemoteWipeActivityListener implements IEventListener { | ||
|
||
/** @var IActvityManager */ | ||
private $activityManager; | ||
|
||
/** @var ILogger */ | ||
private $logger; | ||
|
||
public function __construct(IActvityManager $activityManager, | ||
ILogger $logger) { | ||
$this->activityManager = $activityManager; | ||
$this->logger = $logger; | ||
} | ||
|
||
public function handle(Event $event): void { | ||
if ($event instanceof RemoteWipeStarted) { | ||
$this->publishActivity('remote_wipe_start', $event->getToken()); | ||
} else if ($event instanceof RemoteWipeFinished) { | ||
$this->publishActivity('remote_wipe_finish', $event->getToken()); | ||
} | ||
} | ||
|
||
private function publishActivity(string $event, IToken $token): void { | ||
$activity = $this->activityManager->generateEvent(); | ||
$activity->setApp('core') | ||
->setType('security') | ||
->setAuthor($token->getUID()) | ||
->setAffectedUser($token->getUID()) | ||
->setSubject($event, [ | ||
'name' => $token->getName(), | ||
]); | ||
try { | ||
$this->activityManager->publish($activity); | ||
} catch (BadMethodCallException $e) { | ||
$this->logger->logException($e, [ | ||
'app' => 'core', | ||
'level' => ILogger::WARN, | ||
'message' => 'could not publish activity', | ||
]); | ||
} | ||
} | ||
|
||
} |
71 changes: 71 additions & 0 deletions
71
lib/private/Authentication/Listeners/RemoteWipeNotificationsListener.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/** | ||
* @copyright 2019 Christoph Wurst <christoph@winzerhof-wurst.at> | ||
* | ||
* @author 2019 Christoph Wurst <christoph@winzerhof-wurst.at> | ||
* | ||
* @license GNU AGPL version 3 or any later version | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License as | ||
* published by the Free Software Foundation, either version 3 of the | ||
* License, or (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
namespace OC\Authentication\Listeners; | ||
|
||
use OC\Authentication\Events\ARemoteWipeEvent; | ||
use OC\Authentication\Events\RemoteWipeFinished; | ||
use OC\Authentication\Events\RemoteWipeStarted; | ||
use OC\Authentication\Token\IToken; | ||
use OCP\AppFramework\Utility\ITimeFactory; | ||
use OCP\EventDispatcher\Event; | ||
use OCP\EventDispatcher\IEventListener; | ||
use OCP\Notification\IManager as INotificationManager; | ||
|
||
class RemoteWipeNotificationsListener implements IEventListener { | ||
|
||
/** @var INotificationManager */ | ||
private $notificationManager; | ||
|
||
/** @var ITimeFactory */ | ||
private $timeFactory; | ||
|
||
public function __construct(INotificationManager $notificationManager, | ||
ITimeFactory $timeFactory) { | ||
$this->notificationManager = $notificationManager; | ||
$this->timeFactory = $timeFactory; | ||
} | ||
|
||
public function handle(Event $event): void { | ||
if ($event instanceof RemoteWipeStarted) { | ||
$this->sendNotification('remote_wipe_start', $event->getToken()); | ||
} else if ($event instanceof RemoteWipeFinished) { | ||
$this->sendNotification('remote_wipe_finish', $event->getToken()); | ||
} | ||
} | ||
|
||
private function sendNotification(string $event, IToken $token): void { | ||
$notification = $this->notificationManager->createNotification(); | ||
$notification->setApp('auth') | ||
->setUser($token->getUID()) | ||
->setDateTime($this->timeFactory->getDateTime()) | ||
->setObject('token', $token->getId()) | ||
->setSubject($event, [ | ||
'name' => $token->getName(), | ||
]); | ||
$this->notificationManager->notify($notification); | ||
} | ||
|
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to send those as normal notifications,
or more like the silent notification when a notification is deleted on another device?
Similar to nextcloud/notifications#318
That would allow us, to send it only to the affected device.
In that case I would simply trigger an event and make the notifications app listen to it and then do it's magic there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me. Can we do this in a follow-up PR? The little refactoring exercise here is needed to also add e-mail notifications 😉