Fix illegible text color in columns Size and Modified on dark theme #11823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested review from
skjnldsv,
jancborchardt,
rullzer and
juliusknorr
skjnldsv
approved these changes
Oct 16, 2018
juliusknorr
requested changes
Oct 16, 2018
Signed-off-by: Alexey Pyltsyn <lex61rus@gmail.com>
lex111
force-pushed
the
fix-illegible-text-color-in-size-and-modified-columns
branch
2 times, most recently
from
a0bcac1 to
66d2333
Compare
|
Hi guys, please watch this PR 😃 |
jancborchardt
approved these changes
Oct 18, 2018
|
@juliushaertl can you check if your technical feedback was fixed? :) |
juliusknorr
approved these changes
Oct 18, 2018
|
Yes, fine by me now. Does this also work for you @skjnldsv ? |
|
@lex111 Can you add a signoff message to your commits as described here https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work |
lex111
force-pushed
the
fix-illegible-text-color-in-size-and-modified-columns
branch
2 times, most recently
from
70834d5 to
968a63a
Compare
…rework after review Signed-off-by: Alexey Pyltsyn <lex61rus@gmail.com>
lex111
force-pushed
the
fix-illegible-text-color-in-size-and-modified-columns
branch
from
968a63a to
30cbd13
Compare
|
@juliushaertl done ✔️ |
|
friendly ping @denismosolov I'm not late? 😄 |
Good for me ;) |
skjnldsv
added
4. to release
Then press also the green button ;) |
You rock! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11441