Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use href & target attribute for NcListItem in search result #41800

Closed
nfebe opened this issue Nov 28, 2023 · 0 comments · Fixed by #42062
Closed

Use href & target attribute for NcListItem in search result #41800

nfebe opened this issue Nov 28, 2023 · 0 comments · Fixed by #42062
Assignees
@nfebe
Labels
1. to develop Accepted and waiting to be taken care of enhancement

Comments

@nfebe
Copy link
Contributor

nfebe commented Nov 28, 2023 •
edited
Loading

Bug description

Use href of NcListItem once nextcloud-libraries/nextcloud-vue#4880 is completed.
@nfebe nfebe added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 28, 2023
@nfebe nfebe added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 28, 2023
@nfebe nfebe self-assigned this Nov 28, 2023
@nfebe nfebe mentioned this issue Nov 28, 2023
Merged
@nfebe nfebe changed the title [Bug]: Use href attribute for NcListItem in search result Use href attribute for NcListItem in search result Nov 28, 2023
@nfebe nfebe added enhancement and removed bug labels Nov 28, 2023
@nfebe nfebe changed the title Use href attribute for NcListItem in search result Use href & target attribute for NcListItem in search result Dec 6, 2023
@nfebe nfebe mentioned this issue Dec 6, 2023
Merged
3 tasks
nfebe added a commit that referenced this issue Dec 6, 2023
@nfebe
Correct semantics for link opening in global search
de1601b 
Following the update of `NcListItem` to allow control over
 where and how passed `hrefs` open, the search result component
 can now make use of these props.

See : nextcloud-libraries/nextcloud-vue#4923

Resolves :  #41800

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe mentioned this issue Dec 6, 2023
Merged
nfebe added a commit that referenced this issue Dec 6, 2023
@nfebe
Correct semantics for link opening in global search
aa25590 
Following the update of `NcListItem` to allow control over
 where and how passed `hrefs` open, the search result component
 can now make use of these props.

See : nextcloud-libraries/nextcloud-vue#4923

Resolves :  #41800

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
backportbot-nextcloud bot pushed a commit that referenced this issue Dec 6, 2023
@nfebe @backportbot-nextcloud
Correct semantics for link opening in global search
a728bcd 
Following the update of `NcListItem` to allow control over
 where and how passed `hrefs` open, the search result component
 can now make use of these props.

See : nextcloud-libraries/nextcloud-vue#4923

Resolves :  #41800

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
zak39 pushed a commit to zak39/server that referenced this issue Dec 19, 2023
@nfebe @zak39
Correct semantics for link opening in global search
71cb09f 
Following the update of `NcListItem` to allow control over
 where and how passed `hrefs` open, the search result component
 can now make use of these props.

See : nextcloud-libraries/nextcloud-vue#4923

Resolves :  nextcloud#41800

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfebe nfebe

Labels
1. to develop Accepted and waiting to be taken care of enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct semantics for link opening in global search nextcloud/server
2 participants
@nfebe @szaimen