Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old jquery avatars are not using 2 chars on placeholder #19335

Closed
nickvergessen opened this issue Feb 6, 2020 · 3 comments
Closed

Old jquery avatars are not using 2 chars on placeholder #19335

nickvergessen opened this issue Feb 6, 2020 · 3 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug javascript needs info

Comments

@nickvergessen
Copy link
Member

The changes from #18745 need to be ported to core/src/jquery/avatar.js as well.

@matchish Do you want to take care of this?
@nickvergessen nickvergessen added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap javascript labels Feb 6, 2020
@matchish
Copy link
Contributor

matchish commented Feb 8, 2020

@nickvergessen Sure, I'll do it

matchish added a commit that referenced this issue Feb 11, 2020
@matchish
Generate legacy image placeholder text by taking first letters
ba0c6eb 
#19335
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
matchish added a commit that referenced this issue Feb 11, 2020
@matchish
Generate legacy image placeholder text by taking first letters
8e52eaa 
#19335
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
matchish added a commit to squeegeeOrg/nextcloud-server that referenced this issue Feb 11, 2020
@matchish
Generate legacy image placeholder text by taking first letters
d801a84 
nextcloud#19335
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
matchish added a commit to squeegeeOrg/nextcloud-server that referenced this issue Feb 11, 2020
@matchish
Generate legacy image placeholder text by taking first letters
23c3988 
nextcloud#19335
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
@matchish matchish mentioned this issue Feb 11, 2020
Closed
matchish added a commit to squeegeeOrg/nextcloud-server that referenced this issue Feb 25, 2020
@matchish
Generate legacy image placeholder text by taking first letters
a695851 
nextcloud#19335
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
ChristophWurst pushed a commit that referenced this issue Apr 24, 2020
@matchish @ChristophWurst
Generate legacy image placeholder text by taking first letters
df50ce6 
#19335
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
ChristophWurst pushed a commit that referenced this issue Apr 24, 2020
@matchish @ChristophWurst
Generate legacy image placeholder text by taking first letters
ee4eb19 
#19335
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
rullzer pushed a commit that referenced this issue Apr 30, 2020
@matchish @rullzer
Generate legacy image placeholder text by taking first letters
d1e42c1 
#19335
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
npmbuildbot-nextcloud bot pushed a commit that referenced this issue Apr 30, 2020
@matchish @npmbuildbot
Generate legacy image placeholder text by taking first letters
09ecf4b 
#19335
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@szaimen
Copy link
Contributor

szaimen commented May 28, 2021

Is this Issue still valid? If not, please close this issue. Thanks! :)

@szaimen
Copy link
Contributor

szaimen commented May 28, 2021

Seems like this was done in #20634

@szaimen szaimen closed this as completed May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug javascript needs info
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use 2 chars on placeholder in old jquery avatars squeegeeOrg/nextcloud-server
3 participants
@nickvergessen @matchish @szaimen