Skip to content

Commit

Permalink
Merge pull request #9834 from nextcloud/copy-fix
Browse files Browse the repository at this point in the history
Copyright fix, changed vue settings output name and fixes template name
  • Loading branch information
skjnldsv authored Jun 12, 2018
2 parents dbd4da2 + 885b6be commit ed25fc3
Show file tree
Hide file tree
Showing 30 changed files with 460 additions and 48 deletions.
2 changes: 1 addition & 1 deletion .drone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ pipeline:
vue-build-settings:
image: node
commands:
- ./build/vue-builds.sh ./settings/js/main.js
- ./build/vue-builds.sh ./settings/js/settings-vue.js
when:
matrix:
TESTS: vue-builds
Expand Down
1 change: 0 additions & 1 deletion build/vue-builds.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#!/bin/bash

declare -a apps=("./settings/js/main.js" "./apps/updatenotification/js/merged.js")
root=$(pwd)
entryFile=$1

Expand Down
2 changes: 1 addition & 1 deletion settings/Controller/AppSettingsController.php
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public function viewApps(): TemplateResponse {
$params['bundles'] = $this->getBundles();
$this->navigationManager->setActiveEntry('core_apps');

$templateResponse = new TemplateResponse('settings', 'settings', ['serverData' => $params]);
$templateResponse = new TemplateResponse('settings', 'settings-vue', ['serverData' => $params]);
$policy = new ContentSecurityPolicy();
$policy->addAllowedImageDomain('https://usercontent.apps.nextcloud.com');
$templateResponse->setContentSecurityPolicy($policy);
Expand Down
2 changes: 1 addition & 1 deletion settings/Controller/UsersController.php
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ public function usersList() {
$serverData['defaultQuota'] = $defaultQuota;
$serverData['canChangePassword'] = $canChangePassword;

return new TemplateResponse('settings', 'settings', ['serverData' => $serverData]);
return new TemplateResponse('settings', 'settings-vue', ['serverData' => $serverData]);
}

/**
Expand Down
4 changes: 2 additions & 2 deletions settings/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ watch-js:
npm run watch

clean:
rm -f js/main.js
rm -f js/main.js.map
rm -f js/settings-vue.js
rm -f js/settings-vue.js.map

clean-dev:
rm -rf node_modules
Expand Down
5 changes: 4 additions & 1 deletion settings/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,7 @@ make watch-js

# build for production with minification
make build-js-production
```

# clean output files
make clean
```
1 change: 0 additions & 1 deletion settings/js/main.js.map

This file was deleted.

73 changes: 70 additions & 3 deletions settings/js/main.js → settings/js/settings-vue.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions settings/js/settings-vue.js.map

Large diffs are not rendered by default.

15 changes: 10 additions & 5 deletions settings/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion settings/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "settings",
"description": "Nextcloud settings",
"version": "1.1.0",
"version": "1.1.1",
"author": "John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>",
"license": "AGPL3",
"private": true,
Expand Down
22 changes: 22 additions & 0 deletions settings/src/App.vue
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@
<!--
- @copyright Copyright (c) 2018 John Molakvoæ <skjnldsv@protonmail.com>
-
- @author John Molakvoæ <skjnldsv@protonmail.com>
-
- @license GNU AGPL version 3 or any later version
-
- This program is free software: you can redistribute it and/or modify
- it under the terms of the GNU Affero General Public License as
- published by the Free Software Foundation, either version 3 of the
- License, or (at your option) any later version.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU Affero General Public License for more details.
-
- You should have received a copy of the GNU Affero General Public License
- along with this program. If not, see <http://www.gnu.org/licenses/>.
-
-->

<template>
<router-view></router-view>
</template>
Expand Down
24 changes: 23 additions & 1 deletion settings/src/components/appNavigation.vue
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@
<!--
- @copyright Copyright (c) 2018 John Molakvoæ <skjnldsv@protonmail.com>
-
- @author John Molakvoæ <skjnldsv@protonmail.com>
-
- @license GNU AGPL version 3 or any later version
-
- This program is free software: you can redistribute it and/or modify
- it under the terms of the GNU Affero General Public License as
- published by the Free Software Foundation, either version 3 of the
- License, or (at your option) any later version.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU Affero General Public License for more details.
-
- You should have received a copy of the GNU Affero General Public License
- along with this program. If not, see <http://www.gnu.org/licenses/>.
-
-->

<template>
<div id="app-navigation" :class="{'icon-loading': menu.loading}">
<div class="app-navigation-new" v-if="menu.new">
Expand Down Expand Up @@ -28,5 +50,5 @@ export default {
components: {
navigationItem
}
}
};
</script>
21 changes: 21 additions & 0 deletions settings/src/components/appNavigation/navigationItem.vue
Original file line number Diff line number Diff line change
@@ -1,3 +1,24 @@
<!--
- @copyright Copyright (c) 2018 John Molakvoæ <skjnldsv@protonmail.com>
-
- @author John Molakvoæ <skjnldsv@protonmail.com>
-
- @license GNU AGPL version 3 or any later version
-
- This program is free software: you can redistribute it and/or modify
- it under the terms of the GNU Affero General Public License as
- published by the Free Software Foundation, either version 3 of the
- License, or (at your option) any later version.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU Affero General Public License for more details.
-
- You should have received a copy of the GNU Affero General Public License
- along with this program. If not, see <http://www.gnu.org/licenses/>.
-
-->
<template>
<nav-element :id="item.id" v-bind="navElement(item)"
:class="[{'icon-loading-small': item.loading, 'open': item.opened, 'collapsible': item.collapsible&&item.children&&item.children.length>0 }, item.classes]">
Expand Down
22 changes: 22 additions & 0 deletions settings/src/components/popoverMenu.vue
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@
<!--
- @copyright Copyright (c) 2018 John Molakvoæ <skjnldsv@protonmail.com>
-
- @author John Molakvoæ <skjnldsv@protonmail.com>
-
- @license GNU AGPL version 3 or any later version
-
- This program is free software: you can redistribute it and/or modify
- it under the terms of the GNU Affero General Public License as
- published by the Free Software Foundation, either version 3 of the
- License, or (at your option) any later version.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU Affero General Public License for more details.
-
- You should have received a copy of the GNU Affero General Public License
- along with this program. If not, see <http://www.gnu.org/licenses/>.
-
-->

<template>
<ul>
<popover-item v-for="(item, key) in menu" :item="item" :key="key" />
Expand Down
24 changes: 23 additions & 1 deletion settings/src/components/popoverMenu/popoverItem.vue
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@
<!--
- @copyright Copyright (c) 2018 John Molakvoæ <skjnldsv@protonmail.com>
-
- @author John Molakvoæ <skjnldsv@protonmail.com>
-
- @license GNU AGPL version 3 or any later version
-
- This program is free software: you can redistribute it and/or modify
- it under the terms of the GNU Affero General Public License as
- published by the Free Software Foundation, either version 3 of the
- License, or (at your option) any later version.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU Affero General Public License for more details.
-
- You should have received a copy of the GNU Affero General Public License
- along with this program. If not, see <http://www.gnu.org/licenses/>.
-
-->

<template>
<li>
<!-- If item.href is set, a link will be directly used -->
Expand All @@ -24,5 +46,5 @@
<script>
export default {
props: ['item']
}
};
</script>
22 changes: 22 additions & 0 deletions settings/src/components/userList.vue
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@
<!--
- @copyright Copyright (c) 2018 John Molakvoæ <skjnldsv@protonmail.com>
-
- @author John Molakvoæ <skjnldsv@protonmail.com>
-
- @license GNU AGPL version 3 or any later version
-
- This program is free software: you can redistribute it and/or modify
- it under the terms of the GNU Affero General Public License as
- published by the Free Software Foundation, either version 3 of the
- License, or (at your option) any later version.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU Affero General Public License for more details.
-
- You should have received a copy of the GNU Affero General Public License
- along with this program. If not, see <http://www.gnu.org/licenses/>.
-
-->

<template>
<div id="app-content" class="user-list-grid" v-on:scroll.passive="onScroll">
<div class="row" id="grid-header" :class="{'sticky': scrolled && !showConfig.showNewUserForm}">
Expand Down
22 changes: 22 additions & 0 deletions settings/src/components/userList/userRow.vue
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@
<!--
- @copyright Copyright (c) 2018 John Molakvoæ <skjnldsv@protonmail.com>
-
- @author John Molakvoæ <skjnldsv@protonmail.com>
-
- @license GNU AGPL version 3 or any later version
-
- This program is free software: you can redistribute it and/or modify
- it under the terms of the GNU Affero General Public License as
- published by the Free Software Foundation, either version 3 of the
- License, or (at your option) any later version.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU Affero General Public License for more details.
-
- You should have received a copy of the GNU Affero General Public License
- along with this program. If not, see <http://www.gnu.org/licenses/>.
-
-->

<template>
<!-- Obfuscated user: Logged in user does not have permissions to see all of the data -->
<div class="row" v-if="Object.keys(user).length ===1">
Expand Down
22 changes: 22 additions & 0 deletions settings/src/main.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@
/*
* @copyright Copyright (c) 2018 John Molakvoæ <skjnldsv@protonmail.com>
*
* @author John Molakvoæ <skjnldsv@protonmail.com>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/

import Vue from 'vue';
import { sync } from 'vuex-router-sync';
import App from './App.vue';
Expand Down
27 changes: 25 additions & 2 deletions settings/src/router.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,26 @@
/*
* @copyright Copyright (c) 2018 John Molakvoæ <skjnldsv@protonmail.com>
*
* @author John Molakvoæ <skjnldsv@protonmail.com>
* @author Julius Härtl <jus@bitgrid.net>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/

import Vue from 'vue';
import Router from 'vue-router';
import Users from './views/Users';
Expand All @@ -9,8 +32,8 @@ Vue.use(Router);
* This is the list of routes where the vuejs app will
* take over php to provide data
* You need to forward the php routing (routes.php) to
* /settings/main.php, where the vue-router will ensure
* the proper route.
* the settings-vue template, where the vue-router will
* ensure the proper route.
* ⚠️ Routes needs to match the php routes.
*/

Expand Down
Loading

0 comments on commit ed25fc3

Please sign in to comment.