fix: Use proper file id for direct editing #4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
fix/direct-create
branch
from
98f45ea to
69f715d
Compare
juliusknorr
force-pushed
the
fix/direct-create
branch
from
69f715d to
249701a
Compare
Signed-off-by: Julius Knorr <jus@bitgrid.net>
…t editing Signed-off-by: Julius Knorr <jus@bitgrid.net>
juliusknorr
force-pushed
the
fix/direct-create
branch
from
249701a to
cf83444
Compare
|
Added a cypress test for this |
juliusknorr
added
3. to review
|
@elzody I fail to validate this locally on iOS/Android due to issues with my build environments with that. I'd vote to review and merge, then we can test on the daily instance with real devices and we can backport once double checked. However cypress test should mirror what the clients do in terms of API calls, so I'm pretty sure this is covered well enough with the new test |
elzody
approved these changes
Dec 6, 2024
|
All right, seems something is still odd, when testing on iOS i end up with 0kb files. Need to figure out what is different there compared to the cypress tests. |
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @marinofaggiana there was an issue creating new files on iOS which I could reproduce with curl.
I assume this broke with some refactoring, but not sure where, requiring a test to avoid future regressions
Still to do: