fix: pressing Enter submits guest name input
#3992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
elzody
added
3. to review
elzody
requested review from
blizzz,
juliusknorr,
luka-nextcloud and
max-nextcloud
blizzz
approved these changes
Sep 5, 2024
susnux
reviewed
Sep 5, 2024
| @@ -7,7 +7,9 @@ | |||
| :out-transition="true" | |||
| size="small" | |||
| :show.sync="show"> | |||
| <div class="modal__content" data-cy="guestNameModal"> | |||
| <form class="modal__content" | |||
There was a problem hiding this comment.
Not needed, just migrate this to NcDialog and set is-form prop :)
There was a problem hiding this comment.
That sounds more reasonable, I will take a look :D
marcoambrosini
approved these changes
Sep 6, 2024
jancborchardt
approved these changes
Sep 6, 2024
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enterkey #3990Summary
With this PR the guest name input field is automatically focused, and you can submit it by pressing the
Enterkey. This makes it faster to input the name and get to the document, and follows the behavior users expect.This is done by moving the dialog content into a
<form>element, and using the form submit action. It also includes a few styling changes which I think make the dialog look better (but I'm not a designer :D)Example
Before
After (video)
vokoscreenNG-2024-09-05_14-00-57.webm
Checklist