fix: Emit notification on mentions #3960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
juliusknorr
added
enhancement
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
elzody
reviewed
Sep 14, 2024
juliusknorr
force-pushed
the
fix/mention-notification
branch
2 times, most recently
from
d1cbd64 to
08e5649
Compare
6 tasks
juliusknorr
force-pushed
the
fix/mention-notification
branch
from
08e5649 to
b7a435d
Compare
elzody
approved these changes
Sep 27, 2024
Signed-off-by: Julius Härtl <jus@bitgrid.net>
elzody
force-pushed
the
fix/mention-notification
branch
from
b7a435d to
2955627
Compare
This was referenced Sep 27, 2024
|
@juliushaertl hey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems we totally missed this part when implementing the initial mention support back in the days.
This will emit a notification to mentioned users that can be clicked, just like it works in text.