Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check for mimetype before processing new file from template #3958

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix: Check for mimetype before processing new file from template #3958

merged 1 commit into from
Aug 29, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 29, 2024 •
edited
Loading

Fix nextcloud/whiteboard#113

Otherwise we will try to apply richdocuments logic to other template files

@juliusknorr
fix: Check for mimetype before processing new file from template
6ef8be8 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr requested review from mejo- and elzody August 29, 2024 07:12
@juliusknorr juliusknorr added bug Something isn't working 3. to review Ready to be reviewed labels Aug 29, 2024
@juliusknorr juliusknorr requested a review from hweihwang August 29, 2024 07:12
mejo-
mejo- approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible

@juliusknorr juliusknorr merged commit 4c37f2a into main Aug 29, 2024
62 checks passed
@juliusknorr juliusknorr deleted the fix/noid/event-mimetype-check branch August 29, 2024 07:18
@juliusknorr juliusknorr mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@elzody elzody Awaiting requested review from elzody elzody is a code owner

@hweihwang hweihwang Awaiting requested review from hweihwang

Assignees
No one assigned
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Whiteboard templates - error: Unable to create new file from template
2 participants
@juliusknorr @mejo-