Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(open-pdf): open pdf with richdocuments via file-action #3654

Merged
merged 4 commits into from
May 6, 2024
Merged

test(open-pdf): open pdf with richdocuments via file-action #3654

merged 4 commits into from
May 6, 2024

Conversation

elzody
Copy link
Contributor

@elzody elzody commented May 3, 2024 •
edited
Loading

  • Target version: main

Summary

This PR introduces Cypress testing for the fix from #3645, which fixes the file action for opening PDF files using richdocuments instead of the files PDF viewer.

TODO

  • Properly check for files PDF viewer
  • Make sure the GitHub Cypress workflow includes the files PDF viewer app

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@elzody elzody added bug Something isn't working 3. to review Ready to be reviewed regression labels May 3, 2024
@elzody elzody requested a review from juliusknorr May 3, 2024 18:22
@elzody elzody self-assigned this May 3, 2024
@elzody elzody requested review from max-nextcloud and enjeck May 3, 2024 18:22
@elzody elzody marked this pull request as draft May 3, 2024 18:24
@elzody elzody force-pushed the fix/cypress-pdf-file-action branch 2 times, most recently from 061a04e to 963083f Compare May 3, 2024 18:51
elzody added 4 commits May 3, 2024 14:53
@elzody
test(open-pdf): can open pdf with richdocuments file action
916b06c 
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@elzody
test(open-pdf): can open pdf with files pdf viewer
51a9b16 
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@elzody
fix(test): properly check for files pdf viewer
2519ebf 
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@elzody
fix(test): update github cypress workflow to clone files_pdfviewer
cbced64 
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@elzody elzody force-pushed the fix/cypress-pdf-file-action branch from 963083f to cbced64 Compare May 3, 2024 18:54
@elzody elzody marked this pull request as ready for review May 3, 2024 18:54
@juliusknorr juliusknorr merged commit b12770f into main May 6, 2024
56 checks passed
@juliusknorr juliusknorr deleted the fix/cypress-pdf-file-action branch May 6, 2024 21:24
@juliusknorr
Copy link
Member

/backport to stable29

@juliusknorr
Copy link
Member

/backport to stable28

@juliusknorr
Copy link
Member

/backport to stable27

@backportbot backportbot bot mentioned this pull request May 6, 2024
Merged
This was referenced May 6, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

@enjeck enjeck Awaiting requested review from enjeck

Assignees

@elzody elzody

Labels
3. to review Ready to be reviewed bug Something isn't working feedback-requested regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elzody @juliusknorr