feat!: Add more helpful descriptions to recommended files #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
susnux
reviewed
Feb 28, 2025
| @@ -78,6 +79,21 @@ export default { | |||
| type: Boolean, | |||
| default: false, | |||
| }, | |||
| timestamp: { | |||
| type: Number, | |||
| default: null, | |||
There was a problem hiding this comment.
Can this ever be null? If not its easier to require it.
Suggested change
| default: null, | |
| required: true, |
susnux
reviewed
Feb 28, 2025
Comment on lines
+118
to
+127
| if (this.reason === 'recently-edited') { | ||
| return t('recommendations', 'Last updated {timeAgo}', { timeAgo: this.formattedTime }) | ||
| } | ||
| if (this.reason === 'recently-shared') { | ||
| return t('recommendations', 'Shared with you {timeAgo}', { timeAgo: this.formattedTime }) | ||
| } | ||
| if (this.reason === 'recently-commented') { | ||
| return t('recommendations', 'Last commented on {timeAgo}', { timeAgo: this.formattedTime }) | ||
| } | ||
| return null |
There was a problem hiding this comment.
So timestamp must be available as a prop as otherwise this will fail if timestamp is null but reason is one of those.
susnux
requested changes
Feb 28, 2025
Comment on lines
+87
to
+96
| setup(props) { | ||
| if (!props.timestamp) { | ||
| return | ||
| } | ||
| const { formattedTime } = useFormatDateTime(props.timestamp * 1000, { | ||
| ignoreSeconds: true, | ||
| }) | ||
| return { | ||
| formattedTime, | ||
| } |
There was a problem hiding this comment.
This is not how setup context work. Setup is executed once before the mount / after creation of the component. So if the props are changed you do not get the formatted time.
So if timestamp is required it should look like:
Suggested change
| setup(props) { | |
| if (!props.timestamp) { | |
| return | |
| } | |
| const { formattedTime } = useFormatDateTime(props.timestamp * 1000, { | |
| ignoreSeconds: true, | |
| }) | |
| return { | |
| formattedTime, | |
| } | |
| setup(props) { | |
| const { formattedTime } = useFormatDateTime(computed(() => props.timestamp * 1000), { | |
| ignoreSeconds: true, | |
| }) | |
| return { | |
| formattedTime, | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #841