Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deferrable notification apps #652

Merged
merged 3 commits into from
Jul 9, 2020
Merged

Deferrable notification apps #652

merged 3 commits into from
Jul 9, 2020

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jun 4, 2020 •
edited
Loading

@nickvergessen nickvergessen added this to the Nextcloud 20 milestone Jun 4, 2020
@nickvergessen nickvergessen changed the title Techdebt/noid/deferrable notification apps Deferrable notification apps Jun 4, 2020
@nickvergessen nickvergessen mentioned this pull request Jun 4, 2020
Merged
2 tasks
@nickvergessen
Group pushing the notifications
f84085c 
For notify() this doesn't make any difference for now,
but for markProcessed() it reduces the number of connections drastically.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Implement the notifications app as IDeferrableApp
5356d7d 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the techdebt/noid/deferrable-notification-apps branch from 101c4bf to 5356d7d Compare July 8, 2020 12:44
@nickvergessen
Automatically defer on deletion
1966541 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen marked this pull request as ready for review July 8, 2020 12:53
rullzer
rullzer approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this 🚀

@nickvergessen nickvergessen merged commit 6fc32f7 into master Jul 9, 2020
@nickvergessen nickvergessen deleted the techdebt/noid/deferrable-notification-apps branch July 9, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees
No one assigned
Labels
3. to review enhancement feature: push 📲 technical debt
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @rullzer