Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(push): Show error when internet connection is disabled in configuration #2189

Merged
merged 1 commit into from
Feb 13, 2025
Merged

feat(push): Show error when internet connection is disabled in configuration #2189

merged 1 commit into from
Feb 13, 2025

Conversation

SystemKeeper
Copy link
Contributor

image

occ config:system:set --type boolean --value false has_internet_connection

@SystemKeeper SystemKeeper force-pushed the feat/noid/show-warning-connection-disabled branch from 44609c9 to c7d780c Compare February 13, 2025 15:42
@SystemKeeper
feat(push): Show error when internet connection is disabled in config…
e310cb1 
…uration

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper SystemKeeper force-pushed the feat/noid/show-warning-connection-disabled branch from c7d780c to e310cb1 Compare February 13, 2025 15:53
@github-actions GitHub Actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 8909 was 8700 (+2.4%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nextcloud nextcloud deleted a comment from github-actions bot Feb 13, 2025
@SystemKeeper
Copy link
Contributor Author

/backport to stable31

@SystemKeeper
Copy link
Contributor Author

/backport to stable30

@SystemKeeper
Copy link
Contributor Author

/backport to stable29

@SystemKeeper SystemKeeper merged commit a125b27 into master Feb 13, 2025
47 checks passed
@SystemKeeper SystemKeeper deleted the feat/noid/show-warning-connection-disabled branch February 13, 2025 16:43
This was referenced Feb 13, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SystemKeeper @nickvergessen