Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use vars for repeated calls #2188

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Feb 11, 2025

Small optimization, no functional changes.

@solracsf solracsf added this to the Nextcloud 32 milestone Feb 11, 2025

This comment was marked as outdated.

This comment was marked as outdated.

@solracsf
Copy link
Member Author

Query count bot is outdated.

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a huge diff there is nothing gained and it will break backports if needed, so I'm hesitant

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 8909 was 8700 (+2.4%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen nickvergessen merged commit 0f3e74d into master Feb 14, 2025
48 checks passed
@nickvergessen nickvergessen deleted the useVarsCodeRepeat branch February 14, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants