Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make header icon opaque when focus or hovered with notification #1214

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jun 2, 2022

This is to align with the other header icons and to prevent the outline to be dimmed when focused.

Needs #1209

Scenario Before After Note
Not focused with notification Screenshot from 2022-06-02 16-09-46 Screenshot from 2022-06-02 16-09-46 same as before. opacity = 1
Focused with notification Screenshot from 2022-06-02 16-09-57 Screenshot from 2022-06-02 16-10-58-1 opacity kept to 1
Hovered with notification Screenshot from 2022-06-02 16-18-46 Screenshot from 2022-06-02 16-19-22 opacity kept to 1
Not focused without notification Screenshot from 2022-06-02 16-31-38 Screenshot from 2022-06-02 16-31-38 change to opacity = 0.85 to align with contact. Search is 0.6, don't know why.
Focused without notification Screenshot from 2022-06-02 16-06-19 Screenshot from 2022-06-02 16-06-19 same as before
Hovered without notification Screenshot from 2022-06-02 16-24-11 Screenshot from 2022-06-02 16-24-11 same as before

@artonge artonge added this to the Nextcloud 25 milestone Jun 2, 2022
@artonge artonge requested a review from nickvergessen as a code owner June 2, 2022 11:24
@artonge artonge self-assigned this Jun 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9599 was 9300 (+3.21%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@artonge artonge force-pushed the fix/header_icon_opacity branch from 88b15b0 to e50eb5d Compare June 2, 2022 14:06
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9610 was 9300 (+3.33%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@artonge artonge force-pushed the fix/header_icon_opacity branch from e50eb5d to 0e34736 Compare June 2, 2022 14:26
@artonge artonge changed the title Make header icon opaque Make header icon opaque when focus or hovered with notification Jun 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9619 was 9300 (+3.43%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@artonge artonge force-pushed the fix/header_icon_opacity branch from 0e34736 to 401c72e Compare June 2, 2022 14:30
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9613 was 9300 (+3.36%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@artonge artonge force-pushed the fix/header_icon_opacity branch 3 times, most recently from 8743e68 to f7032d8 Compare June 2, 2022 17:34
@nickvergessen
Copy link
Member

Also here needs a rebase

This is to align with the other header icons

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the fix/header_icon_opacity branch from f7032d8 to 95928d9 Compare June 7, 2022 11:13
@artonge artonge merged commit 9458471 into master Jun 7, 2022
@artonge artonge deleted the fix/header_icon_opacity branch June 7, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants