Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance docs readability #2612

Merged

Conversation

iNtEgraIR2021
Copy link
Contributor

Summary

I applied all findings returned by markdownlint for the Markdown docs files of this project to enhance the readability of the code.

I also enabled the the syntax highlighting for the code blocks to further enhance the readability.

Until now the docs where not easy to read in dark(er) environments so I also enabled the automatic theme switcher based on the browser's prefers-color-scheme header.

Checklist

Copy link
Contributor

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, I believe in addition to this jsonc is valid for JSON with Comments and should not be replaced.

@Grotax
Copy link
Member

Grotax commented Mar 13, 2024

Thanks for the fixes, I believe in addition to this jsonc is valid for JSON with Comments and should not be replaced.

Seems like that makes no difference, mkdocs still renders the comments nicely
grafik

iNtEgraIR2021 and others added 2 commits April 1, 2024 10:47
Signed-off-by: Petra Mirelli <80395360+iNtEgraIR2021@users.noreply.github.com>
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Signed-off-by: Petra Mirelli <80395360+iNtEgraIR2021@users.noreply.github.com>
Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax force-pushed the iNtEgraIR2021-enhance-docs-readability branch from d80e834 to 1dab00d Compare April 1, 2024 08:48
@Grotax Grotax added the Skip-Changelog No changelog update is required, minor change label Apr 1, 2024
@Grotax Grotax enabled auto-merge (rebase) April 1, 2024 08:48
@Grotax
Copy link
Member

Grotax commented Apr 1, 2024

Thanks :)

@Grotax Grotax merged commit 8c36f1d into nextcloud:master Apr 1, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog No changelog update is required, minor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants