-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Import related tags to articles (Categories) #1248
Conversation
Signed-off-by: Jimmy Huynh <jimmy.huynh@etu.unistra.fr>
Signed-off-by: Jimmy Huynh <jimmy.huynh@etu.unistra.fr>
Signed-off-by: Jimmy Huynh <jimmy.huynh@etu.unistra.fr>
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine to me. But it will need tests.
If an article has been changed at the actual feed provider, it is automatically updated (old items, which no longer exist in the feed, are not updated for obvious reasons). But since this is 'only' a transitional problem, I honestly wouldn't do anything to force-refetch it.
Using text seems reasonable, as it's unknown how long the content will be. I'm not sure if 'tag' is the best name for it, since I personally associate it with a tagging feature for the user for sorting and filtering (NC does the same with 'Collaborative tags'). The fetched categories should then also be added into |
Signed-off-by: Jimmy Huynh <jimmy.huynh@etu.unistra.fr>
Signed-off-by: Jimmy Huynh <jimmy.huynh@etu.unistra.fr>
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
To do
|
+ added setter/getters that work with arrays to simplify use case Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
Signed-off-by: Jimmy Huynh <linkatox@gmail.com>
Signed-off-by: Jimmy Huynh <linkatox@gmail.com>
Thanks for your quick replies and support. Features and related tests have been successfully implemented according to your guidance. Check it out and let us know about what you think ! |
The searchindex is a concatenated string of all search terms. So adding something like |
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
Signed-off-by: Marco Nassabain <marco.nassabain@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LinkJim!
I just wanted to try it on my test instance but found no feed with categories included. Any suggestions? |
Since it is an optional element (specification), not all feeds have it. The easiest example of a feed that contains categories is the Nextcloud News feed. You can find it in the explore page, or you can subscribe manually to it via this url: https://nextcloud.com/blogfeed |
Yes I know .. I've tried multiple news sites and blogs, but found none with a category tag. |
Changed - Add BATS as integration tests (#1213) - Update FeedFetcher to import categories from feeds (#1248) - Update serialization of item to include categories (#1248) - Make PHPStan stricter (#955) - Search: Add folder search (#1215) - Improve test coverage (#1263) - Allow directly adding a feed without going through the discovery process (#1265) Fixed - Do not show deleted feeds in item list (#1214) - Fix update queries (#1211)
Changed - Add BATS as integration tests (#1213) - Update FeedFetcher to import categories from feeds (#1248) - Update serialization of item to include categories (#1248) - Make PHPStan stricter (#955) - Search: Add folder search (#1215) - Improve test coverage (#1263) - Allow directly adding a feed without going through the discovery process (#1265) Fixed - Do not show deleted feeds in item list (#1214) - Fix update queries (#1211) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Changed - Add BATS as integration tests (#1213) - Update FeedFetcher to import categories from feeds (#1248) - Update serialization of item to include categories (#1248) - Make PHPStan stricter (#955) - Search: Add folder search (#1215) - Improve test coverage (#1263) - Allow directly adding a feed without going through the discovery process (#1265) Fixed - Do not show deleted feeds in item list (#1214) - Fix update queries (#1211) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Changed - Add BATS as integration tests (nextcloud#1213) - Update FeedFetcher to import categories from feeds (nextcloud#1248) - Update serialization of item to include categories (nextcloud#1248) - Make PHPStan stricter (nextcloud#955) - Search: Add folder search (nextcloud#1215) - Improve test coverage (nextcloud#1263) - Allow directly adding a feed without going through the discovery process (nextcloud#1265) Fixed - Do not show deleted feeds in item list (nextcloud#1214) - Fix update queries (nextcloud#1211) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Authors : Jimmy HUYNH (@LinkJim) - Marco NASSABAIN (@mnassabain)
🚀 Feature
Import related tags for each article
We are already working on sharing articles with users and on social media. (pr existants)
In case of sharing articles on social medias, we thought that sharing posts, would be more relevant if hashtags were automatically generated. Being that generating tags based on a text is a complex problem, we would use the tags retrieved from the RSS feeds instead.
This is an example of usage that the newly added "tags" field would offer. But we think that there are surely more advantages.
💻 Implementation
💡 Questions
✅ To do
Any recommandation would be appreciated, thanks. ;-)