Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard shortcuts are active even when searching #2738

Closed
3 tasks done
mchugh19 opened this issue Aug 15, 2024 · 3 comments · Fixed by #2803
Closed
3 tasks done

Keyboard shortcuts are active even when searching #2738

mchugh19 opened this issue Aug 15, 2024 · 3 comments · Fixed by #2803
Labels
bug

Comments

@mchugh19
Copy link

IMPORTANT

  • I have read the CONTRIBUTING.md and followed the provided tips
  • I accept that the issue will be closed without comment if I do not check here
  • I accept that the issue will be closed without comment if I do not fill out all items in the issue template.

Explain the Problem

While the news app is open, click the nextcloud search bar and type. If you type the letters j or k, the selection on the news reader changes, rather than entering the text into the search bar.
Expected behavior would be that the keyboard shortcuts are only active if there isn't an overlay window or if you are able to type in another area.

Steps to Reproduce

See explain
@mchugh19 mchugh19 added the bug label Aug 15, 2024
@lakshyeahh
Copy link

I have understood the problem, just few lines of handling edge cases should work. You can assign me.

@SMillerDev
Copy link
Contributor

Please make a pull request, no need to be assigned to an issue.

@lakshyeahh
Copy link

Right sir.

@wofferl wofferl mentioned this issue Oct 13, 2024
Merged
@Grotax Grotax mentioned this issue Oct 14, 2024
Merged
Grotax added a commit that referenced this issue Oct 14, 2024
@Grotax
Release 25.0.0-alpha10
bfd8e40 
Changed
- Require NC 29 or 30, dropped support for NC 28
- Require PHP 8.2 or higher

Fixed
- Scroll position is not reset when switching between articles & feeds (#2548)
- Unread counter does not count down when folders or feeds are marked read (#2800)
- Query fetching status didn't work (#2800)
- Keyboard shortcuts are active even when searching (#2738)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax added a commit that referenced this issue Oct 14, 2024
@Grotax
Release 25.0.0-alpha10
d21cb5a 
Changed
- Require NC 29 or 30, dropped support for NC 28
- Require PHP 8.2 or higher

Fixed
- Scroll position is not reset when switching between articles & feeds (#2548)
- Unread counter does not count down when folders or feeds are marked read (#2800)
- Query fetching status didn't work (#2800)
- Keyboard shortcuts are active even when searching (#2738)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Keyboard shortcuts are active even when searching wofferl/news
3 participants
@mchugh19 @SMillerDev @lakshyeahh