Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mailbox being renamed after every update #6252

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Fix mailbox being renamed after every update #6252

merged 1 commit into from
Apr 21, 2022

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Apr 15, 2022 •
edited
Loading

Fix #6179

How to test:

  1. Have a mailbox inside another mailbox (e.g. Inbox -> Inbox.FooBar).
  2. Open the three dot menu of the inner mailbox.
  3. Toggle the 'Sync in Background` checkbox.
  4. Observe that the name of the mailbox does not change anymore.

@st3iny st3iny added this to the v1.12.0 milestone Apr 15, 2022
@st3iny st3iny self-assigned this Apr 15, 2022
@st3iny
Copy link
Member Author

st3iny commented Apr 15, 2022

/backport to stable1.11

@st3iny
Copy link
Member Author

st3iny commented Apr 15, 2022

CI will be fixed after #6251

@GretaD
Copy link
Contributor

GretaD commented Apr 20, 2022

the problem is solved, but now the delete mailbox action is shown only when i click "sync background"

@GretaD
Copy link
Contributor

GretaD commented Apr 20, 2022

the problem is solved, but now the delete mailbox action is shown only when i click "sync background"

scratch that, the problem is on master.

GretaD
GretaD approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@st3iny
Fix mailbox being renamed after every update
ccc2490 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the fix/6179/mailbox-name-after-patch branch from 49acd9d to ccc2490 Compare April 21, 2022 10:39
@st3iny
Copy link
Member Author

st3iny commented Apr 21, 2022

Rebased to fix CI

@st3iny
Copy link
Member Author

st3iny commented Apr 21, 2022

Test failures are unrelated

@st3iny st3iny merged commit b25da7c into main Apr 21, 2022
@st3iny st3iny deleted the fix/6179/mailbox-name-after-patch branch April 21, 2022 11:46
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD GretaD approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees

@st3iny st3iny

Labels
3. to review bug
Projects
None yet
Milestone
v1.12.0
Development

Successfully merging this pull request may close these issues.

Enabling background sync on a folder changes the display name of the folder
2 participants
@st3iny @GretaD