Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preview for image attachment #5898

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Add preview for image attachment #5898

merged 1 commit into from
Jan 10, 2022

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Dec 21, 2021 •
edited
Loading

fixes #5701

  • fit the full view on the screen, no scrolling
  • fit the mobile view on the screen, no scrolling

@GretaD GretaD self-assigned this Dec 23, 2021
@GretaD GretaD added this to the v1.12.0 milestone Dec 23, 2021
@GretaD GretaD marked this pull request as ready for review December 23, 2021 14:47
@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 27, 2021 •
edited by GretaD
Loading

  • BUG the modal is shown as soon as just one of the attachments is a picture. It should only be available to an attachment that is an image. Nothing else.

Bildschirmfoto von 2021-12-27 11-23-24

^ tested with pic & md file

@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 27, 2021 •
edited by GretaD
Loading

  • BUG images are cropped. Try sending a portrait mode image. It will show landscape with the bottom cropped off

@GretaD
Copy link
Contributor Author

GretaD commented Dec 27, 2021 •
edited by ChristophWurst
Loading

  • BUG images are cropped. Try sending a portrait mode image. It will show landscape with the bottom cropped off

i cannot reproduce this one, but im assuming its because the size used to be isMobile: full ? large. I changed it into large only and added overflow scroll. Can you please test, or send me that image you could reproduce

@GretaD
Copy link
Contributor Author

GretaD commented Dec 27, 2021 •
edited
Loading

  • BUG images are cropped. Try sending a portrait mode image. It will show landscape with the bottom cropped off

i cannot reproduce this one, but im assuming its because the size used to be isMobile: full ? large. I changed it into large only and added overflow scroll. Can you please test, or send me that image you could reproduce

i can reproduce and the scrolling fixed it css fixed it

@GretaD GretaD force-pushed the enhanc/attachment-preview branch 2 times, most recently from 0b77437 to 011303b Compare December 28, 2021 09:29
@GretaD GretaD marked this pull request as draft December 28, 2021 15:13
@GretaD GretaD force-pushed the enhanc/attachment-preview branch from feb9fe7 to 6dd37fa Compare December 29, 2021 13:12
@GretaD

This comment has been minimized.

Sign in to view
@GretaD GretaD marked this pull request as ready for review December 29, 2021 13:38
@ChristophWurst

This comment has been minimized.

Sign in to view
@GretaD GretaD requested a review from st3iny January 3, 2022 14:09
st3iny
st3iny reviewed Jan 4, 2022
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overflow of tall pictures is still not fixed. I manually added overflow: auto to .modal-container and it worked fine (showed a vertical scroll bar).

@GretaD
Copy link
Contributor Author

GretaD commented Jan 4, 2022 •
edited
Loading

The overflow of tall pictures is still not fixed. I manually added overflow: auto to .modal-container and it worked fine (showed a vertical scroll bar).

the thing is that it should fit the screen and not scroll. I fixed it with scrolling but then i checked how viewer does and it doesnt scroll.

@GretaD
Copy link
Contributor Author

GretaD commented Jan 4, 2022 •
edited
Loading

please give it a final test. the mobile version of preview its a bit small but readable. I cannot find a solution to fit the image on the screen for portrait and not brake images that are horizontally long for mobile. E.g
testhorixontalll

st3iny
st3iny approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Images inside modals were still cropped but I deployed a fix. Please squash all commits and we are ready to merge.

@GretaD
Add preview for mail attachment
a6ef40b 
Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD force-pushed the enhanc/attachment-preview branch from cc56612 to a6ef40b Compare January 10, 2022 11:29
@GretaD GretaD merged commit b0a462b into main Jan 10, 2022
@GretaD GretaD deleted the enhanc/attachment-preview branch January 10, 2022 15:49
@Bibo-Joshi Bibo-Joshi mentioned this pull request Jan 27, 2022
Open
3 tasks
@ChristophWurst ChristophWurst mentioned this pull request May 17, 2022
Closed
@ChristophWurst ChristophWurst changed the title Add preview for mail attachment Add preview for image attachment Jun 2, 2022
@ChristophWurst ChristophWurst mentioned this pull request Jun 2, 2022
Closed
@ChristophWurst ChristophWurst mentioned this pull request Jun 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

Assignees

@GretaD GretaD

Labels
3. to review enhancement
Projects
None yet
Milestone
v1.12.0
Development

Successfully merging this pull request may close these issues.

Ability to directly view attachment from email
3 participants
@GretaD @ChristophWurst @st3iny